Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] Remove URL reference from DocBlock #1059

Merged
merged 1 commit into from
May 6, 2021

Conversation

JakeQZ
Copy link
Contributor

@JakeQZ JakeQZ commented May 6, 2021

The description was initially copied-and-pasted from a similar DocBlock, but its
new home has nothing to do with URLs.

The description was initially copied-and-pasted from a similar DocBlock, but its
new home has nothing to do with URLs.
@JakeQZ JakeQZ added the cleanup label May 6, 2021
@JakeQZ JakeQZ added this to the 6.0.0 milestone May 6, 2021
@JakeQZ JakeQZ requested a review from oliverklee May 6, 2021 00:14
@JakeQZ JakeQZ self-assigned this May 6, 2021
@JakeQZ
Copy link
Contributor Author

JakeQZ commented May 6, 2021

This commit may be cleaner due to already having newlines after sentences in the DocBlock - see #1054 (comment)

That was not deliberate. WinMerge copes well with 'diffing' changes where odd words are moved onto the next line. GitHub does not. But I would say that the choice and availability of tools should not compromise other factors.

@oliverklee oliverklee merged commit 92c1121 into main May 6, 2021
@oliverklee oliverklee deleted the cleanup/test/css/docblock-semicolon branch May 6, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants