Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the utitlity classes as @internal? #713

Closed
oliverklee opened this issue Sep 15, 2019 · 1 comment · Fixed by #715
Closed

Mark the utitlity classes as @internal? #713

oliverklee opened this issue Sep 15, 2019 · 1 comment · Fixed by #715
Assignees
Milestone

Comments

@oliverklee
Copy link
Contributor

Hi @zoliszabo, @JakeQZ, should we mark the utility classes (CssConcatenator and ArrayIntersector) as @internal so it is clear that they might be removed, moved around or have their API changed without prior notice?

@oliverklee oliverklee added this to the 3.0.0 milestone Sep 15, 2019
@oliverklee oliverklee self-assigned this Sep 15, 2019
@JakeQZ
Copy link
Contributor

JakeQZ commented Sep 15, 2019

This also occurred to me.

Though now #712 is committed, I don't envisage much likelyhood of that happening - they fulfill the purpose for which they were intended - even #668 is unlikely to have an impact.

OTOH, if there were to be a breaking change it would avoid the need for a new major version. And anyone using them is likely to be fairly clued up and judicious about potentially breaking updates and take heed of such a notice - it doesn't prevent them being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants