Skip to content

Commit

Permalink
[BUGFIX] Disable tests that are failing due to a bug in the CSS parser
Browse files Browse the repository at this point in the history
As this is a bug in a 3rd-party library, we should fix it there, and
our build should not be red in the meantime.

Part of #1129
  • Loading branch information
oliverklee committed Dec 16, 2021
1 parent 24bc9b6 commit a403a88
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
4 changes: 3 additions & 1 deletion tests/Unit/Css/CssDocumentTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ public function provideSelector(): array
'class' => ['.classy'],
'ID' => ['#toc'],
'attribute (presence)' => ['[title]'],
'attribute (value match)' => ['[href=https://example.org]'],
// disabled as this currently breaks due to a bug in the CSS parser
// @see https://github.com/sabberworm/PHP-CSS-Parser/issues/347
// 'attribute (value match)' => ['[href=https://example.org]'],
'attribute (word match)' => ['[class~=logo]'],
'attribute (hyphenated prefix match)' => ['[lang|=de]'],
'attribute (prefix match)' => ['[href^=#]'],
Expand Down
3 changes: 3 additions & 0 deletions tests/Unit/CssInlinerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -1557,6 +1557,9 @@ public function inlineCssRemovesStyleNodes(): void
*/
public function inlineCssInDebugModeForInvalidCssSelectorThrowsException(): void
{
// @see https://github.com/sabberworm/PHP-CSS-Parser/issues/347
self::markTestSkipped('This test is disabled as it currently is failing due to a bug in the CSS parser.');

$this->expectException(SyntaxErrorException::class);

$subject = CssInliner::fromHtml(
Expand Down

0 comments on commit a403a88

Please sign in to comment.