Skip to content

[BUGFIX] Add missing imports for @throws annotations #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2025
Merged

[BUGFIX] Add missing imports for @throws annotations #897

merged 1 commit into from
Feb 10, 2025

Conversation

oliverklee
Copy link
Collaborator

No description provided.

@oliverklee oliverklee self-assigned this Feb 10, 2025
@coveralls
Copy link

coveralls commented Feb 10, 2025 •
edited
Loading

Coverage Status

coverage: 49.156%. remained the same
when pulling 6b4ec7c on bugfix/import-throws
into 5c440f3 on main.

JakeQZ
JakeQZ approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressed that Stan managed to identify the FQN of the exception class without the use statement.

@JakeQZ JakeQZ merged commit ceec94e into main Feb 10, 2025
21 checks passed
@JakeQZ JakeQZ deleted the bugfix/import-throws branch February 10, 2025 10:40
@oliverklee
Copy link
Collaborator Author

Impressed that Stan managed to identify the FQN of the exception class without the use statement.

It didn't - that's why this change fixes some PHPStan warnings. ;-)

oliverklee added a commit that referenced this pull request Feb 10, 2025
@oliverklee
[BUGFIX] Add missing imports for @throws annotations
1c89085 
This is the V8.x backport of #897.
@oliverklee oliverklee mentioned this pull request Feb 10, 2025
Merged
@JakeQZ
Copy link
Collaborator

JakeQZ commented Feb 11, 2025

Impressed that Stan managed to identify the FQN of the exception class without the use statement.

It didn't - that's why this change fixes some PHPStan warnings. ;-)

You're right, it just assumed FQN from the current namespace.

JakeQZ pushed a commit that referenced this pull request Feb 11, 2025
@oliverklee
[BUGFIX] Add missing imports for @throws annotations (#900)
980e00d 
This is the V8.x backport of #897.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels
bug cleanup to-backport
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ