Skip to content

[CLEANUP] Avoid Hungarian notion for the Commentable interface #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

oliverklee
Copy link
Collaborator

@oliverklee oliverklee commented Jan 25, 2025

Also adapt the implementing classes accordingly.

Part of #756.

@coveralls
Copy link

coveralls commented Jan 25, 2025

Coverage Status

coverage: 42.138%. remained the same
when pulling ca9b608 on task/hungarian-4
into 540b315 on main.

@oliverklee oliverklee changed the title [TASK] Avoid Hungarian notion for the Commtentable interface [TASK] Avoid Hungarian notion for the Commentable interface Jan 25, 2025
@oliverklee oliverklee force-pushed the task/hungarian-4 branch 2 times, most recently from 166fac1 to 5c79f36 Compare January 25, 2025 09:50
@oliverklee oliverklee changed the title [TASK] Avoid Hungarian notion for the Commentable interface [CLEANUP] Avoid Hungarian notion for the Commentable interface Jan 25, 2025
Also adapt the implementing classes accordingly.

Part of #756.
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't help but notice that the various classes implementing Commentable seen to have exactly the same implementation. So I think this could be tidied up by providing a trait for a 'standard' Commentable implementation - but is beyond the scope of this PR.

@JakeQZ JakeQZ merged commit 24f44c2 into main Jan 25, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/hungarian-4 branch January 25, 2025 19:25
@JakeQZ
Copy link
Collaborator

JakeQZ commented Jan 25, 2025

I can't help but notice that the various classes implementing Commentable seen to have exactly the same implementation. So I think this could be tidied up by providing a trait for a 'standard' Commentable implementation - but is beyond the scope of this PR.

Added #813 to capture this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants