Skip to content

[TASK] Deprecate Parser::setCharset() and Parser::getCharset() #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2024
Merged

[TASK] Deprecate Parser::setCharset() and Parser::getCharset() #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).

### Deprecated

- Deprecate `Parser::setCharset()` and `Parser::getCharset()` (#688)
- Deprecate `DeclarationBlock::createBorderShorthand()` (#578)
- Deprecate `DeclarationBlock::createFontShorthand()` (#580)
- Deprecate `DeclarationBlock::createDimensionsShorthand()` (#579)
Expand Down
4 changes: 4 additions & 0 deletions src/Parser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ public function __construct($sText, ?Settings $oParserSettings = null, $iLineNo
* Sets the charset to be used if the CSS does not contain an `@charset` declaration.
*
* @param string $sCharset
*
* @deprecated will be removed in version 9.0.0 with #687
*/
public function setCharset($sCharset): void
{
Expand All @@ -43,6 +45,8 @@ public function setCharset($sCharset): void

/**
* Returns the charset that is used if the CSS does not contain an `@charset` declaration.
*
* @deprecated will be removed in version 9.0.0 with #687
*/
public function getCharset(): void
{
Expand Down