Skip to content

[CLEANUP] Ensure all tests actually have an assertion #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2024
Merged

[CLEANUP] Ensure all tests actually have an assertion #609

merged 1 commit into from
Jun 21, 2024

Conversation

oliverklee
Copy link
Collaborator

This avoids the "This test did not perform any assertions" warning from PHPUnit.

@oliverklee
[CLEANUP] Ensure all tests actually have an assertion
1ee4a9b 
This avoids the "This test did not perform any assertions" warning
from PHPUnit.
@oliverklee oliverklee requested review from sabberworm and JakeQZ June 21, 2024 20:05
@oliverklee oliverklee self-assigned this Jun 21, 2024
JakeQZ
JakeQZ approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had also noticed the "1 risky test".

An alternative would have been to declare the test method to 'expect no exception', whereas what you have put in actually strenthens the testing, so is double-bubble.

@JakeQZ JakeQZ merged commit 6388ae1 into main Jun 21, 2024
18 checks passed
@JakeQZ JakeQZ deleted the cleanup/no-assertion branch June 21, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverklee @JakeQZ