[CLEANUP] Extract CSSFunction methods parseName and parseArguments #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeQZ
added
cleanup
refactor
JakeQZ
force-pushed
the
refactor/css-function/parse
branch
from
9ac8a42 to
8b226e0
Compare
JakeQZ
force-pushed
the
refactor/css-function/parse
branch
from
8b226e0 to
9329187
Compare
|
Looking again, this change is independent of the functional change in #390, so isn't a prerequisite for that implementation. |
JakeQZ
modified the milestones:
8.6.0 - Critical Features,
9.0.0: Drop support for PHP < 7.2 and clean up things
|
I think I have found a more specific solution to the |
JakeQZ
force-pushed
the
refactor/css-function/parse
branch
3 times, most recently
from
c32482c to
d80eac3
Compare
Also - Update the `parse` method signature to use PHP7 type hints; - Remove subsequently redundant DocBlock entries; - Ditto for same-named method in subclasses to avoid contravariance. This is the refactoring change from #390.
JakeQZ
force-pushed
the
refactor/css-function/parse
branch
from
d80eac3 to
875bd71
Compare
I've rebased with that change included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also
parsefunction signature to use PHP7 type hints;This is the refactoring change from #390.