Skip to content

[BUGFIX] Don't return objects from data providers #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Jun 3, 2025

The same objects may be provided to multiple tests. If a test manipulates an object,
it will no longer be in the initial expected state for other tests.

This is the backport of #1260.

@JakeQZ JakeQZ requested a review from oliverklee June 3, 2025 12:57
@JakeQZ JakeQZ self-assigned this Jun 3, 2025
@JakeQZ JakeQZ added bug testing PRs/issues adding additional tests only, or primarily testing-focused developer-specific Issues that only affect maintainers, contributors, and people submitting PRs backport labels Jun 3, 2025
The same objects may be provided to multiple tests.
If a test manipulates an object,
it will no longer be in the initial expected state for other tests.

This is the backport of #1260.
@JakeQZ JakeQZ force-pushed the bugfix/8.x/dataprovider-objects branch from 632218e to 874e9ca Compare June 3, 2025 12:59
@oliverklee oliverklee merged commit 4c0e4a8 into v8.x Jun 3, 2025
22 checks passed
@oliverklee oliverklee deleted the bugfix/8.x/dataprovider-objects branch June 3, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug developer-specific Issues that only affect maintainers, contributors, and people submitting PRs testing PRs/issues adding additional tests only, or primarily testing-focused
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants