Skip to content

bug with parsing multiple comments #173

Closed
Closed
@snake

Description

@snake

When parsing a rule or csslist, trailing comments (those comments after the rule/list) are consumed as part of a final consumeWhitespace call, meaning we don't see these reported for the next rule in the set (or the next set).

Consider the following cases:

div {/*Find Me!*/left:10px; /*Find Me Too!*/text-align:left;}
Both of these comments should be returned (one for each rule), but the latter is not.

/*Find Me!*/div {left:10px; text-align:left;} /*Find Me Too!*/a {left:10px;}
Both of these comments should be returned (one for each csslist), but the latter is not.

I'd like this fixed so I can use this to parse RTL directives for css rules/lists reliably again. Moodle recently upgraded to 8.3.0 and this broke our RTL.

Please see the linked fix proposal.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions