Skip to content

Rework logic between CSSList:: parseList() and parseListItem() #1211

Open
@JakeQZ

Description

@JakeQZ

Currently parseListItem() returns null to indicate that the end of the list has been reached, and false to indicate that an invalid item was found but parsing of the remaining items should continue.

This is confusing, and the mixed type return value does not work well with static analysis tools like PHPStan.

Perhaps instead parseList() should have the responsibility for checking for the end of the list itself.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions