Skip to content

Move selector validation to Selector constructor #1041

Open
@JakeQZ

Description

@JakeQZ

Selector::isValid() is currently used by callers before creating a Selector. In all those cases an exception is thrown if it is not valid. It would be cleaner if the Selector constructor handled that check and itself threw the exception.

However, there may be cases where a Selector is constructed without this check, including in third-party code...

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions