Skip to content

MCR-3578 expand MCRNameMerger for modsperson #2774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
erodde wants to merge 8 commits into
base: main
Choose a base branch
from
Open

MCR-3578 expand MCRNameMerger for modsperson #2774

erodde wants to merge 8 commits into from

Conversation

@erodde
Copy link
Contributor

@erodde erodde commented Dec 12, 2025 •
edited
Loading

Link to jira.

This PR: #2643, but renamed branch and Jira Ticket.

I expanded the MCRNameMerger in UBO for modsperson.

  1. It can handle mods:alternativeName now and considers them when determining if two names are probably the same.
  2. If first name is the same and one of the family names contains the other, the names are considered as "probablySameAs". This takes double-barreled names (Doppelnamen) into account.

@erodde erodde requested a review from fluetze December 12, 2025 10:37
@erodde erodde mentioned this pull request Dec 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluetze fluetze Awaiting requested review from fluetze

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erodde