MCR-3551 Allow hiding of publicly available derivates #1227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 10, 2025
toKrause
force-pushed
the
issues/MCR-3551_Allow-hiding-of-publicly-available-derivates
branch
2 times, most recently
from
9d720de to
9e3bb66
Compare
toKrause
force-pushed
the
issues/MCR-3551_Allow-hiding-of-publicly-available-derivates
branch
from
9e3bb66 to
6ecd2e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to jira.
To be used in conjunction with MyCoRe-Org/mycore#2724.
To be used in conjunction with MyCoRe-Org/mycore-classifications#30.
This is the implementation currently used for MACAU since 2021. It might not be the cleanest implementation, especially the duplicated parts in MIR.
It may be better to have a simpler implementation with less duplication in Java-Code, i.e. by extending
isDisplayedEnabledDerivate, which is already called in most cases. That method however, is part of the ACL system and concerns itself with permission, but this issue is not a paermissions-issue. Also, there are more usages of that method and it is not clear which of that uses can be considered 'public dissemination'. Needs to be discussed.