Skip to content

Commit

Permalink
[maglev] Fix constructor stub check in OptimizeOsr
Browse files Browse the repository at this point in the history
... since Maglev deopt info does not track the bytecode offset
for the construct stubs anymore.

Fixed: chromium:1466844
Bug: v8:7700
Change-Id: Ic4ca99ebec3f2e380b704ec92f1f0b86c6f3aecd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4717491
Commit-Queue: Olivier Flückiger <olivf@chromium.org>
Auto-Submit: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: Olivier Flückiger <olivf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#89200}
  • Loading branch information
victorgomes authored and V8 LUCI CQ committed Jul 26, 2023
1 parent 526f4d8 commit b41676c
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/runtime/runtime-test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -744,9 +744,8 @@ RUNTIME_FUNCTION(Runtime_OptimizeOsr) {
// TODO(olivf) It's possible that a valid osr_offset happens to be the
// construct stub range but. We should use OptimizedFrame::Summarize here
// instead.
if (!(function->IsConstructor() &&
(current_offset == BytecodeOffset::ConstructStubCreate() ||
current_offset == BytecodeOffset::ConstructStubInvoke()))) {
if (!function->IsConstructor() ||
current_offset != BytecodeOffset::None()) {
osr_offset = OffsetOfNextJumpLoop(isolate, bytecode_array,
current_offset.ToInt());
}
Expand Down

0 comments on commit b41676c

Please sign in to comment.