[heap] Restore method inlining

crrev.com/c/4652188 accidentally removed V8_INLINE from VisitYoungObjectViaSlot. This CL restores inlining to what it used to be. Bug: chromium:1462941 Change-Id: I5431908eca8f3ac97f6d96cd5dbdbf442487e8a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4681765 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#89026}
Mutter45 · Jul 19, 2023 · 960a4be · 960a4be
1 parent 564cfa4
commit 960a4be
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/src/heap/concurrent-marking.cc b/src/heap/concurrent-marking.cc
@@ -107,7 +107,7 @@ class YoungGenerationConcurrentMarkingVisitor final
   }
 
   template <typename TSlot>
-  bool VisitObjectViaSlotInRemeberedSet(TSlot slot) {
+  V8_INLINE bool VisitObjectViaSlotInRemeberedSet(TSlot slot) {
     return VisitYoungObjectViaSlot<ObjectVisitationMode::kPushToWorklist,
                                    SlotTreatmentMode::kReadOnly>(this, slot);
   }

diff --git a/src/heap/marking-visitor-utility-inl.h b/src/heap/marking-visitor-utility-inl.h
@@ -25,7 +25,7 @@ enum class SlotTreatmentMode {
 template <ObjectVisitationMode visitation_mode,
           SlotTreatmentMode slot_treatment_mode, typename Visitor,
           typename TSlot>
-bool VisitYoungObjectViaSlot(Visitor* visitor, TSlot slot) {
+V8_INLINE bool VisitYoungObjectViaSlot(Visitor* visitor, TSlot slot) {
   typename TSlot::TObject target;
   if constexpr (Visitor::EnableConcurrentVisitation()) {
     target = slot.Relaxed_Load(visitor->cage_base());

diff --git a/src/heap/minor-mark-sweep-inl.h b/src/heap/minor-mark-sweep-inl.h
@@ -71,7 +71,8 @@ void YoungGenerationMainMarkingVisitor::VisitPointersImpl(HeapObject host,
 }
 
 template <typename TSlot>
-bool YoungGenerationMainMarkingVisitor::VisitObjectViaSlotInRemeberedSet(
+V8_INLINE bool
+YoungGenerationMainMarkingVisitor::VisitObjectViaSlotInRemeberedSet(
     TSlot slot) {
   return VisitYoungObjectViaSlot<ObjectVisitationMode::kVisitDirectly,
                                  SlotTreatmentMode::kReadWrite>(this, slot);

diff --git a/src/heap/minor-mark-sweep.h b/src/heap/minor-mark-sweep.h
@@ -45,7 +45,7 @@ class YoungGenerationMainMarkingVisitor final
   V8_INLINE void IncrementLiveBytesCached(MemoryChunk* chunk, intptr_t by);
 
   template <typename TSlot>
-  bool VisitObjectViaSlotInRemeberedSet(TSlot slot);
+  V8_INLINE bool VisitObjectViaSlotInRemeberedSet(TSlot slot);
 
   V8_INLINE bool ShortCutStrings(HeapObjectSlot slot, HeapObject* heap_object);