[maglev][arm] Remove maglev-arm temporary flag

Bug: v8:7700
Change-Id: I1e05a7422a071bb743f41ba6766070bda50f334b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4650485
Auto-Submit: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#88551}

src/codegen/compiler.h

@@ -48,14 +48,7 @@ struct ScriptStreamingData;
 namespace maglev {
 class MaglevCompilationJob;
 
-static inline bool IsMaglevEnabled() {
-  // TODO(victorgomes): Currently arm ignores the --maglev flag.
-#ifdef V8_TARGET_ARCH_ARM
-  return v8_flags.maglev_arm;
-#else
-  return v8_flags.maglev;
-#endif
-}
+static inline bool IsMaglevEnabled() { return v8_flags.maglev; }
 
 static inline bool IsMaglevOsrEnabled() {
   return IsMaglevEnabled() && v8_flags.maglev_osr;

src/flags/flag-definitions.h

@@ -472,10 +472,6 @@ DEFINE_BOOL(force_emit_interrupt_budget_checks, false,
 #define V8_ENABLE_MAGLEV_BOOL true
 DEFINE_BOOL(maglev, false, "enable the maglev optimizing compiler")
 DEFINE_WEAK_IMPLICATION(future, maglev)
-#ifdef V8_TARGET_ARCH_ARM
-DEFINE_EXPERIMENTAL_FEATURE(maglev_arm, "enable maglev on arm")
-DEFINE_IMPLICATION(maglev_arm, maglev)
-#endif
 DEFINE_EXPERIMENTAL_FEATURE(
     maglev_future,
     "enable maglev features that we want to ship in the not-too-far future")
@@ -528,9 +524,6 @@ DEFINE_IMPLICATION(stress_maglev, maglev)
 DEFINE_WEAK_VALUE_IMPLICATION(stress_maglev, invocation_count_for_maglev, 4)
 #else
 #define V8_ENABLE_MAGLEV_BOOL false
-#ifdef V8_TARGET_ARCH_ARM
-DEFINE_BOOL_READONLY(maglev_arm, false, "enable maglev on arm")
-#endif
 DEFINE_BOOL_READONLY(maglev, false, "enable the maglev optimizing compiler")
 DEFINE_BOOL_READONLY(
     maglev_future, false,

test/cctest/test-cpu-profiler.cc

@@ -1256,9 +1256,6 @@ static void TickLines(bool optimize) {
 #ifdef V8_ENABLE_MAGLEV
   // TODO(v8:7700): Also test maglev here.
   v8_flags.maglev = false;
-#ifdef V8_TARGET_ARCH_ARM
-  v8_flags.maglev_arm = false;
-#endif
 #endif  // V8_ENABLE_MAGLEV
 #endif  // !defined(V8_LITE_MODE) && defined(V8_ENABLE_TURBOFAN)
   CcTest::InitializeVM();

test/mjsunit/mjsunit.status

@@ -1962,9 +1962,6 @@
   'compiler/number-comparison-truncations': [FAIL],
   'regress/regress-2132': [FAIL],
   'compiler/regress-1199345': [FAIL],
-  # Maglev doesn't suppress BigInt size errors on truncation.
-  'compiler/bigint-shift-left': [FAIL],
-  'compiler/bigint-multiply-truncate': [FAIL],
   'wasm/bigint-opt': [FAIL],
   # Maglev doesn't inline the call being tested here.
   'compiler/call-with-arraylike-or-spread': [FAIL],
@@ -2006,53 +2003,19 @@
   'regress/regress-map-invalidation-2': [FAIL],
 }], # variant == stress_maglev or variant == stress_maglev_future
 
+['(variant == stress_maglev or variant == stress_maglev_future) and (arch != arm)', {
+  # Maglev doesn't suppress BigInt size errors on truncation.
+  # On Arm that works, since we always _and_ the shift amount first.
+  'compiler/bigint-shift-left': [FAIL],
+  'compiler/bigint-multiply-truncate': [FAIL],
+}], # variant == stress_maglev or variant == stress_maglev_future
+
 ['variant == maglev_no_turbofan or variant == stress_maglev_no_turbofan', {
   # Relies on OSR from maglev to turbofan due to a missing interrupt check.
   # TODO(olivf): Add interrupt check for inlined functions.
   'regress/regress-1376663': [SKIP],
 }], # variant == maglev_no_turbofan or variant == stress_maglev_no_turbofan
 
-# TODO(victorgomes): Remove these once we support Maglev on arm.
-['arch == arm', {
-  'baseline/test-osr-maglev': [FAIL],
-  'baseline/test-osr-maglev-tf': [FAIL],
-  'maglev/add-number': [FAIL],
-  'maglev/add-smi': [FAIL],
-  'maglev/call-js-runtime': [FAIL],
-  'maglev/call-runtime-for-pair': [FAIL],
-  'maglev/destructuring-assignment-with-exclude-properties': [FAIL],
-  'maglev/get-template-object': [FAIL],
-  'maglev/inner-function': [FAIL],
-  'maglev/int32-branch': [FAIL],
-  'maglev/lazy-deopt-with-onstack-activation': [FAIL],
-  'maglev/lazy-deopt-without-onstack-activation': [FAIL],
-  'maglev/lda-global-inside-typeof': [FAIL],
-  'maglev/lda-global': [FAIL],
-  'maglev/lda-module-variable': [FAIL],
-  'maglev/literals': [FAIL],
-  'maglev/load-named': [FAIL],
-  'maglev/negate': [FAIL],
-  'maglev/omit-default-ctors-array-iterator': [FAIL],
-  'maglev/omit-default-ctors': [FAIL],
-  'maglev/osr-from-ml-to-tf' : [SKIP],
-  'maglev/tier-to-ml-to-tf': [SKIP],
-  'maglev/shift-right-logical-smi': [FAIL],
-  'maglev/shift-right-logical': [FAIL],
-  'maglev/shift-right-smi': [FAIL],
-  'maglev/shift-right': [FAIL],
-  'maglev/spill-double': [FAIL],
-  'maglev/sta-module-variable': [FAIL],
-  'maglev/string-compare': [FAIL],
-  'maglev/super-ic': [FAIL],
-  'maglev/undefined-or-null-branch': [FAIL],
-  'maglev/unstable-map-transition': [FAIL],
-  'maglev/regress/regress-1405651': [FAIL],
-  'maglev/polymorphic-load': [FAIL],
-  'maglev/polymorphic-load-migration': [FAIL],
-  'maglev/typedarray-resizablearraybuffer': [FAIL],
-  'maglev/phi-untagging-conversions': [FAIL],
-}], # arch == arm
-
 ##############################################################################
 ['clang_coverage and mode == debug', {
   # Too slow tests.