Skip to content

Commit

Permalink
Build: Improve ESLint configuration (jquery#3188)
Browse files Browse the repository at this point in the history
* Bump eslint-config-jquery package to 0.1.4 version

* Add subtask "dist" to "eslint" task and add it to the build task list

* Make gitignore globs more flexible for the "dist" folder

Fixes jquerygh-3169
  • Loading branch information
markelog authored Jun 22, 2016
1 parent 58c6ca9 commit 25d8ccd
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@

npm-debug.log

/dist/jquery*
# Ignore everything in dist folder except for eslint config
/dist/*
!/dist/.eslintrc

/node_modules

/test/node_smoke_tests/lib/ensure_iterability.js
3 changes: 2 additions & 1 deletion Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ module.exports = function( grunt ) {
quiet: true
},
all: ".",
dist: "dist/jquery.js",
dev: [ "src/**/*.js", "Gruntfile.js", "test/**/*.js", "build/**/*.js" ]
},
testswarm: {
Expand Down Expand Up @@ -201,7 +202,7 @@ module.exports = function( grunt ) {
]
);

grunt.registerTask( "default", [ "dev", "test_fast", "compare_size" ] );
grunt.registerTask( "default", [ "dev", "eslint:dist", "test_fast", "compare_size" ] );

grunt.registerTask( "precommit_lint", [ "newer:jsonlint", "newer:eslint:all" ] );
};
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"commitplease": "2.3.1",
"core-js": "2.2.2",
"cross-spawn": "2.2.3",
"eslint-config-jquery": "0.1.2",
"eslint-config-jquery": "0.1.6",
"grunt": "1.0.1",
"grunt-babel": "6.0.0",
"grunt-cli": "1.2.0",
Expand Down

0 comments on commit 25d8ccd

Please sign in to comment.