Merge pull request #702 from MurhafSousli/release/15.0.6

v15.0.6
MurhafSousli · Nov 11, 2024 · d8c3365 · d8c3365 · github-actions · Nov 11, 2024
2 parents dd1641e + 90865a3
commit d8c3365
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 9 deletions.
diff --git a/CHANGELOG.MD b/CHANGELOG.MD
@@ -1,11 +1,13 @@
 # Changelog
 
-## 15.0.4
+## 15.0.6
 
 - Add link in message body even if description was not provided, closes [#697](https://github.com/MurhafSousli/ngx-sharebuttons/issues/697) and [#610](https://github.com/MurhafSousli/ngx-sharebuttons/issues/610).
 - Remove FontAwesome type imports from the share directive, closes [#673](https://github.com/MurhafSousli/ngx-sharebuttons/issues/673).
 - Refactor all inputs to signal inputs.
 
+## 15.0.4 and 15.0.5 are faulty releases
+
 ## 15.0.3
 
 - enhance: enhance: Use injection factory for `SHARE_BUTTONS_CONFIG` and `SHARE_BUTTONS_PROP` to avoid merging custom options with the default options for every share button.

diff --git a/projects/ngx-sharebuttons-demo/src/app/pages/home/home.component.html b/projects/ngx-sharebuttons-demo/src/app/pages/home/home.component.html
@@ -14,7 +14,7 @@ <h3>Share Buttons</h3>
             </a>
           </div>
           <div class="sb-option">
-            <a mat-raised-button routerLink="/share-buttons-component">
+            <a mat-raised-button routerLink="/share-button-component">
               <img src="assets/img/sharebutton-component.svg"/>
               <h3>Single Share Button</h3>
             </a>

diff --git a/projects/ngx-sharebuttons-demo/src/app/shared/overview-content/overview-content.component.ts b/projects/ngx-sharebuttons-demo/src/app/shared/overview-content/overview-content.component.ts
@@ -52,7 +52,7 @@ export class OverviewContentComponent implements OnInit, AfterViewInit, OnDestro
   private fragmentSub$: Subscription;
 
   ngOnInit(): void {
-    this.links = Array.from(this.scrollbar.viewport.nativeElement.querySelectorAll('h2'));
+    this.links = Array.from(this.scrollbar.nativeElement.querySelectorAll('h2'));
     setTimeout(() => {
       this.activeLinkId.set(this.links[0].id);
     });

diff --git a/projects/ngx-sharebuttons-demo/src/app/shared/section-title/section-title.component.ts b/projects/ngx-sharebuttons-demo/src/app/shared/section-title/section-title.component.ts
@@ -1,4 +1,4 @@
-import { Component, SkipSelf, ChangeDetectionStrategy } from '@angular/core';
+import { Component, inject, ChangeDetectionStrategy } from '@angular/core';
 import { RouterLink } from '@angular/router';
 import { NgScrollbar } from 'ngx-scrollbar';
 import { FaIconComponent } from '@fortawesome/angular-fontawesome';
@@ -31,8 +31,8 @@ import { KebabCasePipe } from '../kebab-case.pipe';
 })
 export class SectionTitleComponent {
 
-  iconCaretRight: IconDefinition = faCaretRight;
+  readonly iconCaretRight: IconDefinition = faCaretRight;
+
+  readonly scrollbar: NgScrollbar = inject(NgScrollbar);
 
-  constructor(@SkipSelf() public scrollbar: NgScrollbar) {
-  }
 }
diff --git a/projects/ngx-sharebuttons/package.json b/projects/ngx-sharebuttons/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-sharebuttons",
-  "version": "15.0.4",
+  "version": "15.0.6",
   "license": "MIT",
   "homepage": "https://ngx-sharebuttons.netlify.app/",
   "author": {

diff --git a/projects/ngx-sharebuttons/src/lib/share.service.ts b/projects/ngx-sharebuttons/src/lib/share.service.ts
@@ -103,7 +103,7 @@ export class ShareService {
 
     return Object.entries(shareButton.params).reduce((params: Record<string, string>, [key, realKey]: [string, string]) => {
       // Check if param has a value
-      if (shareButton.requiredParams[key] || computedParams[key]) {
+      if ((shareButton.requiredParams && shareButton.requiredParams[key]) || computedParams[key]) {
         // Check if param has a resolver function
         const resolver: ShareParamsFunc = shareButton.paramsFunc?.[key];
         params[realKey] = resolver ? resolver(computedParams) : computedParams[key];