Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality for modifing graph metadata using UI #456

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jddanna
Copy link
Collaborator

@jddanna jddanna commented May 9, 2021

Updated old PR #364

Fixes #317

Implemented UI for modifying user meta-data which includes the following

  • User will be able to modify graph attributes by clicking on the "edit" button.
  • User will be able to modify description in "Graph Information" tab.
  • User will be able to modify tags, title, name in the edit panel which appears on clicking "edit" button.
  • Corresponding changes will also be reflected in the database.

Gif of the implementation

pull_request

Introduced Problem from original PR:

When all the tags are removed and an update is performed, Elastic search was not updating properly. The map_attributes method wasn't returning the proper name for tags. It was returning tags without a data type because tags was an empty dictionary. In order for elasticSearch to update the tags, it must be in the format of string_tags, so we added a case in map_attributes to append the data type to tags:

if (key == 'tags'): value_type = DataType.forValue("String")

Thanks to @bruce-wayne99 for original PR fix

@jddanna
Copy link
Collaborator Author

jddanna commented May 24, 2021

Adding a dropdown to "Edit" button would help to notify users what content can be updated with the button (metadata).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify graph metadata using UI
1 participant