Issue#378 update cytoscape.js version #387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a pull request template to standardize the description of the proposed changes from contributors. Project contributors will automatically see the template's contents in the pull request body. More details can be found [here](https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/).
…ytoscape.js version 3.2.17 (#2) Fixes Murali-group#396. Refer: cytoscape/cytoscape.js#1533
|
Possible issue: Solution: |
|
Update cytoscape: |
jahandaniyal
requested changes
Jul 17, 2019
There was a problem hiding this comment.
All occurrences of event.Target should be event.target.
Refer- cytoscape/cytoscape.js#1537
| @@ -870,7 +870,7 @@ var graphPage = { | |||
| }, | |||
| onTapGraphElement: function (evt) { | |||
| // get target | |||
| var target = evt.cyTarget; | |||
| var target = evt.Target; | |||
There was a problem hiding this comment.
@JingVT @adbharadwaj - evt.Target is incorrect. It should be evt.target
Refer - cytoscape/cytoscape.js#1537
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Cytoscape.js to v3.2.17. For compatibility, we need to upgrade
cytoscape-context-menusto version 3.0.6 as well.Task list for making sure all features related to Cytoscape.js work properly:
Change LayoutonGraph VisualizationpageCircle,Grid,Concentric,Spring Embedder,Tree,cola.cy.layout()andeles.layout()return the layout rather than chaining the calling object cytoscape/cytoscape.js#1533cola settingsUse Layout EditoronGraph VisualizationpageEdit selected nodesorEdit selected edgesArrange nodescy.layout()andeles.layout()return the layout rather than chaining the calling object cytoscape/cytoscape.js#1533Popup for node or edge
cyprefix on event fields, because we don't merge with the original event (as left open); e.g.cyTarget=>targetcytoscape/cytoscape.js#1537cyTargettoTargetin graphs_page.js.Nodes with multiple background images mentioned in issue Update cytoscape.js version #378
For Example: the node with background-image: Pigeon_silhouette_4874 and background-color: rgb(137,208,245).
Before Upgrade Cytoscape.js (i.e. v2.7):
After Upgrade Cytoscape.js (i.e. v3.2.17):
Support "z-compound-depth" and "z-index-compare" attributes mentioned in issue Update Cytoscape JS version to support Z-index #295
Before Upgrade Cytoscape.js (i.e. v2.7):
After Upgrade Cytoscape.js (i.e. v3.2.17):
Search or Filter nodes and edges
Remove applyMax functions in graphs_page.js which have been deprecated.
Useful Reference: Announcing Cytoscape.js 3.0.0