Repository navigation
Builder.connect(): return the connection when it succeeds (check was inverted) - #37
Open
SanniniciStyle wants to merge 1 commit into
Open
SanniniciStyle wants to merge 1 commit into
SanniniciStyle wants to merge 1 commit into
Conversation
Both Builder.connect() overloads threw "Unable to establish a new connection" when connect() returned true, and returned the connection when it failed. The check is now the right way round, and a failed connection is closed before throwing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclosure: this was found while building WatchSync with heavy AI assistance (Claude Code — "vibe coding", if you like). We work carefully: everything below was verified with the included unit test, but please review it with that in mind.
Both
AdbConnection.Builder.connect()overloads have the check inverted:so a successful connection throws, and a failed one is returned. Now
if (!...), and the failed connection is closed before throwing (it was leaked).AdbConnectionBuilderTestconnects to a minimal plain-text adbd on localhost that accepts at once: