Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added opsdroid #279

Merged
merged 3 commits into from
Apr 9, 2019
Merged

Added opsdroid #279

merged 3 commits into from
Apr 9, 2019

Conversation

jacobtomlinson
Copy link
Contributor

We add issues for beginners and are happy to mentor new contributors through their first open source experiences.

Copy link
Contributor

@vvscode vvscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link should be to label filter ( check other links for example )

@jacobtomlinson
Copy link
Contributor Author

@vvscode ah I totally missed that! Fixed now!

@MunGell
Copy link
Owner

MunGell commented Apr 6, 2019

Hi @jacobtomlinson

Sorry for the wait, do you know what is the difference between "beginner" and "good first issue" labels in this repository?

@jacobtomlinson
Copy link
Contributor Author

No worries. Would be great to get this moved along.

good first issue is exactly that, issues specifically aimed at first time contributors. beginner is the difficults of an issue, there are also intermediate and advanced labels.

@MunGell
Copy link
Owner

MunGell commented Apr 8, 2019

@jacobtomlinson would good first issue be a better choice for this list?

As I understand it, good first issue is a subset of beginner issues, so every good first issue is also a beginner, but not every beginner issue is good for first-time contributors.

Since this repository is a starting point for first-time contributors to find your repository, it sounds like good first issue is a better option for them.

What do you think?

@jacobtomlinson
Copy link
Contributor Author

Sure happy with that.

We intentionally make the good first issue very well described for newbies. Often we put more effort into writing the issue than it would take to implement the change.

The beginner issues are less described and aimed at people who want easy issues but have a bit of entry level knowledge.

I went with beginner because this repo is called awesome-for-beginners. However if you think we should only be targeting first timers I'm happy with that too.

@MunGell
Copy link
Owner

MunGell commented Apr 8, 2019

Ok, I see.

Then I will leave the decision on which label to point new contributors to to you.
I believe this issue might give a little insight: #215

If all ok, please resolve the conflicts and I will merge this PR

Thanks!

@jacobtomlinson
Copy link
Contributor Author

Fixed conflict and went for good first issue.

@MunGell
Copy link
Owner

MunGell commented Apr 9, 2019

Perfect, thanks!

@MunGell MunGell merged commit e25391e into MunGell:master Apr 9, 2019
@jacobtomlinson jacobtomlinson deleted the patch-1 branch April 10, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants