Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

53 # ZeroCode API Testing - REST, KAFKA, SOAP and DB API testing lib #195

Merged
merged 4 commits into from
Feb 23, 2019

Conversation

authorjapps
Copy link
Contributor

No description provided.

@authorjapps
Copy link
Contributor Author

Hello Guys, How to merge this PR? Is there any process to follow to get this approved?

@MunGell
Copy link
Owner

MunGell commented Mar 7, 2018

Hey @authorjapps

I've written contributing guidelines for this repository - please have a look there.
In general - your project is too new and has not formed strong community around it to support new contributors (one of the criteria in the guidelines). I will leave this PR open for some time until you will get a wider community support. Or you can close it and create a new one when you will get more people involved

@MunGell
Copy link
Owner

MunGell commented Feb 11, 2019

Hi @authorjapps

A year passed since you opened this PR and it looks like your repository is active and project is moving forward - great job!

I see that you have good first issue label as well.

Could you please clarify which one is used to label issues for beginners in contribution to open source?

@MunGell MunGell added the rework-needed PR requires changes before merging. See comments label Feb 11, 2019
@authorjapps authorjapps changed the title 53 # ZeroCode REST API and JAVA API testing lib 53 # ZeroCode API Testing - REST, KAFKA, SOAP and DB API testing lib Feb 13, 2019
@authorjapps
Copy link
Contributor Author

Hello @MunGell ,
Thanks for coming back on this.
Label "good first issue" for beginners and "help wanted" is general for all not necessarily for beginners.

@MunGell
Copy link
Owner

MunGell commented Feb 21, 2019

@authorjapps I understand the difference between "help wanted" and "good first issue".
However, in this PR you are suggesting "first-time-high-flight" label.

Could you clarify how is it used and what is the difference between "first-time-high-flight" and "good first issue"?

@authorjapps
Copy link
Contributor Author

Could you clarify how is it used and what is the difference between "first-time-high-flight" and "good first issue"?

Understood, "first-time-high-flight" is creating confusion. I have got rid of that label now and updated with "good first use" label and link.

@MunGell MunGell removed the rework-needed PR requires changes before merging. See comments label Feb 23, 2019
@MunGell MunGell merged commit efdb67d into MunGell:master Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants