Skip to content

Conversation

@pgroot91
Copy link
Contributor

@pgroot91 pgroot91 commented Aug 3, 2025

  1. Make available phpMyAdmin and make sure both the development and test database are accessable. ✅
  2. Add mailpit for testing emails and could also be used during development. ✅
  3. Added a simple test proving the implementation works with mailpit api for email testing. ✅
  4. Updated the pipeline and included mailpit. ✅

@pgroot91 pgroot91 marked this pull request as ready for review August 8, 2025 19:54
@pgroot91
Copy link
Contributor Author

pgroot91 commented Aug 8, 2025

@superdav42 this is ready to be reviewed.

@pgroot91 pgroot91 changed the title Work in progress for phpMyAdmin and Mailpit Add phpMyAdmin and Mailpit in docker workflow Aug 8, 2025
Copy link
Collaborator

@superdav42 superdav42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for updating the readme and everything. The only nitpick is the indention was changed for the entire composer.json file which caused conflicts. I undid the indention changes but preserved the additions.

Thanks!

@superdav42 superdav42 merged commit 8b1cfdf into Multisite-Ultimate:main Aug 13, 2025
18 checks passed
@pgroot91
Copy link
Contributor Author

pgroot91 commented Aug 14, 2025

@superdav42 so what rules are followed and how to set it up properly... i don't see anything in the project.

Maybe we should add linters for the project if we want to follow something. We can even implement something that runs all linter pre-commit.

@superdav42
Copy link
Collaborator

@superdav42 so what rules are followed and how to set it up properly... i don't see anything in the project.

For the most part the rules are in .phpcs.xml.dist but these don't really apply to json files. Really to follow the conventions set there, the json file should be update to use tabs instead of 4 spaces. I have no problem using 2 spaces in the composer.json file. The problem is it's hard to review what the content changes when there's so many white spaces changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants