-
-
Notifications
You must be signed in to change notification settings - Fork 64
Add phpMyAdmin and Mailpit in docker workflow #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add phpMyAdmin and Mailpit in docker workflow #124
Conversation
…t needs to be cleanly rebuild since cleaning doesn't cut it
…ience' of https://github.com/pgroot91/wp-multisite-waas into feature/123-add-phpmyadmin-and-mailpit-for-better-experience
…ilpit-for-better-experience
…ilpit-for-better-experience
…ience' of https://github.com/pgroot91/wp-multisite-waas into feature/123-add-phpmyadmin-and-mailpit-for-better-experience
|
@superdav42 this is ready to be reviewed. |
…ation works for email testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thanks for updating the readme and everything. The only nitpick is the indention was changed for the entire composer.json file which caused conflicts. I undid the indention changes but preserved the additions.
Thanks!
|
@superdav42 so what rules are followed and how to set it up properly... i don't see anything in the project. Maybe we should add linters for the project if we want to follow something. We can even implement something that runs all linter pre-commit. |
For the most part the rules are in .phpcs.xml.dist but these don't really apply to json files. Really to follow the conventions set there, the json file should be update to use tabs instead of 4 spaces. I have no problem using 2 spaces in the composer.json file. The problem is it's hard to review what the content changes when there's so many white spaces changes. |
Uh oh!
There was an error while loading. Please reload this page.