Skip to content

Conversation

@miguelmaso
Copy link
Collaborator

@miguelmaso miguelmaso commented Nov 6, 2025

Changelog

  • Removed commented code (commented code is dead code; if needed, it can be recovered by the version control)
  • Removed unused dependencies:
    • Make compilation faster
    • If the dependencies are needed, them can be added to the submodules (test, benchmark) or to the user project
  • Removed some unused usings (not sure if 100% not used, lets see if it passes the tests)

@miguelmaso miguelmaso requested a review from jmartfrut November 6, 2025 09:22
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Benchmark Results (Julia v1)

Time benchmarks
main ca15cf2... main / ca15cf2...
Constitutive models/Visco-elastic Ψ 0.0477 ± 0.027 ms 0.0483 ± 0.027 ms 0.989 ± 0.79
Constitutive models/Visco-elastic ∂Ψu 0.0625 ± 0.0042 ms 0.0621 ± 0.0043 ms 1.01 ± 0.097
Constitutive models/Visco-elastic ∂Ψuu 0.111 ± 0.015 ms 0.112 ± 0.017 ms 0.992 ± 0.2
Simulations/StaticMechanicalDirichlet 0.161 ± 0.013 s 0.158 ± 0.012 s 1.02 ± 0.11
Simulations/StaticMechanicalNeumann 0.196 ± 0.012 s 0.21 ± 0.015 s 0.935 ± 0.089
Simulations/ViscoElastic 0.0485 h 0.0475 h 1.02
Tensor algebra/δδ_λ_2d 30 ± 0 ns 30 ± 0 ns 1 ± 0
Tensor algebra/δδ_μ_2d 30 ± 0 ns 30 ± 0 ns 1 ± 0
time_to_load 2.54 ± 0.051 s 2.53 ± 0.054 s 1 ± 0.029
Memory benchmarks
main ca15cf2... main / ca15cf2...
Constitutive models/Visco-elastic Ψ 1.24 k allocs: 0.0782 MB 1.24 k allocs: 0.0782 MB 1
Constitutive models/Visco-elastic ∂Ψu 1.36 k allocs: 0.0904 MB 1.36 k allocs: 0.0904 MB 1
Constitutive models/Visco-elastic ∂Ψuu 2.31 k allocs: 0.155 MB 2.31 k allocs: 0.155 MB 1
Simulations/StaticMechanicalDirichlet 1.69 M allocs: 0.118 GB 1.69 M allocs: 0.118 GB 1
Simulations/StaticMechanicalNeumann 2.19 M allocs: 0.14 GB 2.19 M allocs: 0.14 GB 1
Simulations/ViscoElastic 2.72 G allocs: 192 GB 2.72 G allocs: 192 GB 1
Tensor algebra/δδ_λ_2d 0 allocs: 0 B 0 allocs: 0 B
Tensor algebra/δδ_μ_2d 0 allocs: 0 B 0 allocs: 0 B
time_to_load 0.149 k allocs: 11.1 kB 0.149 k allocs: 11.1 kB 1

@jmartfrut jmartfrut merged commit 04288db into main Nov 6, 2025
4 checks passed
@miguelmaso miguelmaso deleted the cleanup branch November 6, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants