Skip to content

Conversation

@miguelmaso
Copy link
Collaborator

@miguelmaso miguelmaso commented Nov 4, 2025

The simulation files have the following properties:

  • The functions are self-contained and should work as an example
  • The functions accept named parameters, such as writevtk and verbose
  • The functions return some value that allows to perform a check

Helper function added to HyperFEM:

  • Io.jl -> projdir Return a folder relative to the HyperFEM dir
  • Io.jl -> filedir Return a folder relative to the current file

Let's see if the tests and benchmraks are fine

@miguelmaso
Copy link
Collaborator Author

Benchmarks will be failing until this PR is merged.

Reason: I've modified a function in test/data/ replacing argument write_vtk by writevtk. Hence, when comparing versions, the old one is inconsistent.

@miguelmaso miguelmaso requested a review from jmartfrut November 4, 2025 19:33
@miguelmaso
Copy link
Collaborator Author

@jmartfrut ready to merge

@jmartfrut jmartfrut merged commit 0bc8b3b into main Nov 6, 2025
3 of 4 checks passed
@miguelmaso miguelmaso deleted the sims-tests branch November 6, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants