You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So, when you're offline, and you try to play, it'll automatically try to launch in Offline Mode, so it asks for your username, right? If you just realized then that you didn't have internet, and you back out of the menu and try again after connecting, it still asks for your offline mode name. This might seem kinda like an edge case, but it happened to me for something like the 5th time today, so I might as well report it.
Not sure if this is too similar to #4356, but that one's mostly focused on sleep rather than not having connection altogether, so yea.
Steps to reproduce
Disconnect from the internet
Open MultiMC
Launch an instance
X out of the popup asking for your offline mode username
Connect to internet (don't close MultiMC)
Launch the instance again
(shows same popup)
Suspected cause
Haven't looked at the code, but I'd assume it's checking for internet when you open up MultiMC, and then just remembers that you don't have internet as long as that process is open? Maybe check for internet at launch-time? idk
This issue is unique
I have searched the issue tracker and did not find an issue describing my bug.
The text was updated successfully, but these errors were encountered:
In the login function of LaunchController, added requestRefresh on the current m_accountToUse.
This allows the accountState of accountToUse to be updated before running through what login is meant to depending on the accountState. This is to allow for the cases where a device might be back online after launching the Launcher. Putting this in the tryagain while loop also allows to check if a users account is expired during the login process.
In the login function of LaunchController, added requestRefresh on the current m_accountToUse.
This allows the accountState of accountToUse to be updated before running through what login is meant to depending on the accountState. This is to allow for the cases where a device might be back online after launching the Launcher. Putting this in the tryagain while loop also allows to check if a users account is expired during the login process.
Operating System
Windows
Description of bug
So, when you're offline, and you try to play, it'll automatically try to launch in Offline Mode, so it asks for your username, right? If you just realized then that you didn't have internet, and you back out of the menu and try again after connecting, it still asks for your offline mode name. This might seem kinda like an edge case, but it happened to me for something like the 5th time today, so I might as well report it.
Not sure if this is too similar to #4356, but that one's mostly focused on sleep rather than not having connection altogether, so yea.
Steps to reproduce
(shows same popup)
Suspected cause
Haven't looked at the code, but I'd assume it's checking for internet when you open up MultiMC, and then just remembers that you don't have internet as long as that process is open? Maybe check for internet at launch-time? idk
This issue is unique
The text was updated successfully, but these errors were encountered: