Proxy config refactor #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jar builds again without errors at this point. There are still improvements to be done though. The absolutely necessary TODO's start with [ConfigRefactor]. |
|
Closes #35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What, briefly, is the purpose of this pull request?
To make using the different configurations easier, both for internal and potential external use in API later
Is this pull request related to an issue with the plugin?
No
What is the status of this pull request? [e.g. In Development, Undergoing Final Testing, Ready]
In Development
Changes
What currently existing parts of the plugin are affected by this pull request
Configuration handling, some other classes outside of that may be changed to comply to the new config standard
What new features are added to the plugin by this pull request
Straight accessibility to config values
Prevention of mistakes in class access / creation by outside sources for future API implementations
Standards
Does this pull request adhere to basic Java coding standards?
Yes
Is the pull request suitably javadoc'd? (E.g. Have you written detailed javadoc on all public methods)
Hopefully it will be, we may need to adjust some of it