fix(hermes): match 'are u there' colloquial check-ins - #40
Merged
Conversation
Screenshot phrase "macha are u there daa ?" missed the greeting classifier (are you vs are u), so clarify polls still fired after #39. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
are you theretoare (?:you|u) thereso screenshot phrasemacha are u there daa ?is treated as a check-in (no clarify polls).Root cause
After #39, live OCI probe showed
macha are u there daa ?→ False whilemacha you there daa ?→ True. Agent log 04:17: clarify tool + interrupt + WAITING_FOR_USER second clarify (career-role choices). Not career-cron session bleed; pending clarify store was empty.Test plan
git diff --check./scripts/public-audit.sh./tests/smoke/run.sh./tests/reliability/run.sh(full PASS)Made with Cursor