Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK setup #2566

Merged
merged 14 commits into from
Jun 13, 2019
Merged

Update SDK setup #2566

merged 14 commits into from
Jun 13, 2019

Conversation

keneanung
Copy link
Member

Brief overview of PR changes/additions

Updates the Qt installed by the SDK to 5.12.2 to be even with appveyor again.

In this light, other dependencies are updated on windows as well.

Motivation for adding to Mudlet

Up-to-date software and a working SDK setup again.

Other info (issues closed, discussion etc)

Closes #2536

@keneanung keneanung requested a review from a team May 24, 2019 09:28
@add-deployment-links
Copy link

add-deployment-links bot commented May 24, 2019

Hey there! Thanks for helping Mudlet improve. 🌟
You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

Translation stats

language translated untranslated percentage done
de_DE 1894 47 97
el_GR 0 1941 0
en_GB 411 1530 21
en_US 11 0 100
es_ES 736 1205 37
fr_FR 200 1741 10
it_IT 1012 929 52
nl_NL 46 1895 2
pl_PL 516 1425 26
pt_PT 262 1679 13
ru_RU 1749 192 90
zh_CN 1005 936 51
zh_TW 0 1941 0

@keneanung
Copy link
Member Author

This is ready for review now!

@keneanung keneanung removed their assignment Jun 2, 2019
@vadi2 vadi2 self-assigned this Jun 3, 2019
Copy link
Member

@vadi2 vadi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script is shutting down without having compiled Mudlet - I'm not sure what is going wrong. How can I view a log / make it pause before quitting?

@keneanung
Copy link
Member Author

If you start it from a powershell as a command (not via right click), at least the compiling bit should stay. If it's the installation of dependencies, it's harder and I'd have to look it up in a bit.

The C:\src\verbose_output.log doesn't give any hints?

@vadi2
Copy link
Member

vadi2 commented Jun 3, 2019

Seems to bomb out compiling yajl with cmake?

==== hunspell compiled and installed ====
==== compiling and installing yajl ====
---- Downloading ----
---- Extracting source distribution ----

7-Zip 18.05 (x64) : Copyright (c) 1999-2018 Igor Pavlov : 2018-04-30

Scanning the drive for archives:
1 file, 84039 bytes (83 KiB)

Extracting archive: C:\src\yajl-2.1.0.tar.gz
--
Path = C:\src\yajl-2.1.0.tar.gz
Type = gzip
Headers Size = 10

Everything is Ok

Size:       552960
Compressed: 84039

7-Zip 18.05 (x64) : Copyright (c) 1999-2018 Igor Pavlov : 2018-04-30

Scanning the drive for archives:
1 file, 552960 bytes (540 KiB)

Extracting archive: C:\src\yajl-2.1.0.tar
--
Path = C:\src\yajl-2.1.0.tar
Type = tar
Physical Size = 552960
Headers Size = 95232
Code Page = UTF-8

Everything is Ok

Folders: 11
Files: 170
Size:       391640
Compressed: 552960
---- changing CMakeLists.txt ----
---- running cmake ----
-- The C compiler identification is unknown
-- Configuring incomplete, errors occurred!
See also "C:/src/yajl-2.1.0/lloyd-yajl-66cb08c/build/CMakeFiles/CMakeOutput.log".
See also "C:/src/yajl-2.1.0/lloyd-yajl-66cb08c/build/CMakeFiles/CMakeError.log".
CMake Error at CMakeLists.txt:17 (PROJECT):
  The CMAKE_C_COMPILER:

    C:/Qt/Tools/mingw530_32/bin/gcc.exe

  is not a full path to an existing compiler tool.

  Tell CMake where to find the compiler by setting either the environment
  variable "CC" or the CMake cache entry CMAKE_C_COMPILER to the full path to
  the compiler, or to the compiler name if it is in the PATH.


Using C:\Qt\5.12.2\mingw73_32 as QT base directory.
Using C:\Qt\Tools\mingw730_32 as MinGW base directory.

@keneanung
Copy link
Member Author

Oh! Remove the folder C:\src\ completely.

It's using data it remembered from the earlier install... I should probably clean up at some point... 🤔

@vadi2
Copy link
Member

vadi2 commented Jun 3, 2019

Agree, a way to run a cleanup install would be good - 1) people can remove it and not get any for having to do manual clean up, 2) when you want to nuke & reinstall it

@vadi2
Copy link
Member

vadi2 commented Jun 3, 2019

On a clean src and LuaRocks, it could not find yajl for stats generation when it started the compile. Both yajl and lua-yajl installed OK, though and there's a yajl.dll in C:\Qt\Tools\mingw730_32\lib\lua\5.1. Do you have the same?

@keneanung
Copy link
Member Author

Hm, worked for appveyor ™️ I'll try again on this machine...

@vadi2
Copy link
Member

vadi2 commented Jun 3, 2019

That it did. Thanks for having a look.

Copy link
Member

@vadi2 vadi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I imagine it'll work well on a fresh install.

@vadi2 vadi2 merged commit 414309d into Mudlet:development Jun 13, 2019
@vadi2
Copy link
Member

vadi2 commented Jun 13, 2019

Merged for release.

@keneanung keneanung deleted the Update-SDK-Qt-to-5.12.2 branch July 26, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Mudlet compiling environment installation
2 participants