fixes #1433 settings now uses existing pointSize #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadi2
approved these changes
Dec 10, 2017
|
Done. |
WackyWormer
pushed a commit
to WackyWormer/Mudlet
that referenced
this pull request
Dec 18, 2017
👍 awesome, thanks for the improvement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
As noted by issue #1433 the settings dialogue does not remember the currently used displayFont pointSize. This change updates the initializer list for dlgProfilePreferences to use the existing pointSize when initializing mFontSize instead of setting it to the hard coded value of 10.
Motivation for adding to Mudlet
Like the person who reported the issue, I also noticed that the settings dialogue did not remember the previously set value. I felt motivated to make this change so that I did not have to re-enter my preferred font size every time I open the settings dialogue.