[pull] master from MariaDB:master #120
Open
+3,060
−251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
START REPLIA was issued during initializing which mean that
even before /docker-entrypoint/initdb.d there was initializtion
going on.
Entrypoints that needed data initialzation didn't complete with
this nicely. Also if there wasn't any initialization there
would be little time for the replication to acheive anything
before being shutdown ready for the final start.
Moved --skip-slave-start to the default docker_temp_server_start
implementation.
Technically this is a compaibility break that is likely to be
of significants if:
* /docker-entrypoint/initdb.d contains a script waiting
for replication to catch up.
The recitifcation to the previous behaviour is:
/docker-entrypoint/initdb.d contains a SQL to START REPLICA.
Recommend also having another script that is:
until healthcheck.sh --replication_io \
--replication_sql \
--replication_seconds_behind_master=0 \
--replication
--no-connect;
do
sleep 1
done
Closes #614
There is an implicit --connect option in healthcheck so that a normal use can be sure MariaDB is running on a tcp socket. There is a case in /docker-entrypoint-initdb.d where its desirable to perform healthchecks for components without a --connect. In this case, use --no-connect in the healthcheck to avoid an implicit --connect test.
As highlighted in #630 a healthcheck.sh --mariadbuprade test will use flock that is provided by util-linux-core on ubi systems.
For 10.5, 10.6, 10.11 and 11.4
10.5.28, 10.6.21, 10.11.11, and 11.4.5 releases
With a few manual hacks on version.
EPEL is missing jemalloc from 10 (but is in 10.1). For a few small released we can do without this. pwgen is also missing from EPEL (bug report https://bugzilla.redhat.com/show_bug.cgi?id=2370234). In the mean time we use a perl command as an alternative. The .test/run.sh is updated to not depend on jemalloc existing. The jemalloc.1 soname that was in focal is removed from the test case.
This reverts commit fb1fb19.
This reverts commit c1e4d2b.
This reverts commit 5003a5b.
Using a releaseversion of 10.1 was sufficent to get jemalloc and the epel-testing version of pwgen installed.
Adjust UBI repo comment to describe why its disabled there. Now we can fetch the key from the archive only to limit the number of URLs host domains.
And general edits/speling fixes.
Make mariadb-dump a one-shot container
This allows the container to finish once the dump as been made to allow the next migration to start. With this, we've used the root user to allow changing of ownership of the mysqldump volume. Because of MDEV-20912 being resolved we don't need to manually change collations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )