[pull] main from jaegertracing:main #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
## Which problem is this PR solving? - part of #2556 ## Description of the changes - This PR removes the dependency of Sort Selector on redux-form. - We could previously sort the traces on homepage, and the value we were selecting on this Sort Selector was reflecting to the SearchTrace page that is responsible to rendering the Sorted Traces list and sorting the traces. This state exchange was previously done by redux-form but now we are directly passing it using react state and component props. - We were also tracking the changes done by a user in this sort selector using a middleware tied to the redux-actions. Now we are not using redux for form state management so tracking logic is directly moved to the part where a sort action takes place, i.e., `handleSortChange` - Removed @types/redux-form as there is no .ts/x file left that is using redux-form. ## How was this change tested? - npm run test - npm run start and using the sort selector ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [rollup-plugin-visualizer](https://redirect.github.com/btd/rollup-plugin-visualizer) | [`5.13.1` -> `5.14.0`](https://renovatebot.com/diffs/npm/rollup-plugin-visualizer/5.13.1/5.14.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>btd/rollup-plugin-visualizer (rollup-plugin-visualizer)</summary> ### [`v5.14.0`](https://redirect.github.com/btd/rollup-plugin-visualizer/blob/HEAD/CHANGELOG.md#5140) [Compare Source](https://redirect.github.com/btd/rollup-plugin-visualizer/compare/v5.13.1...v5.14.0) - Return `flamegraph` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/jaegertracing/jaeger-ui). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45Mi4wIiwidXBkYXRlZEluVmVyIjoiMzkuOTIuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiY2hhbmdlbG9nOmRlcGVuZGVuY2llcyJdfQ==--> Signed-off-by: Mend Renovate <bot@renovateapp.com>
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/upload-artifact](https://redirect.github.com/actions/upload-artifact) | action | minor | `v4.5.0` -> `v4.6.0` | --- ### Release Notes <details> <summary>actions/upload-artifact (actions/upload-artifact)</summary> ### [`v4.6.0`](https://redirect.github.com/actions/upload-artifact/releases/tag/v4.6.0) [Compare Source](https://redirect.github.com/actions/upload-artifact/compare/v4.5.0...v4.6.0) ##### What's Changed - Expose env vars to control concurrency and timeout by [@​yacaovsnc](https://redirect.github.com/yacaovsnc) in [https://github.com/actions/upload-artifact/pull/662](https://redirect.github.com/actions/upload-artifact/pull/662) **Full Changelog**: actions/upload-artifact@v4...v4.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/jaegertracing/jaeger-ui). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45Mi4wIiwidXBkYXRlZEluVmVyIjoiMzkuOTIuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiY2hhbmdlbG9nOmRlcGVuZGVuY2llcyJdfQ==--> Signed-off-by: Mend Renovate <bot@renovateapp.com>
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@babel/eslint-parser](https://babel.dev/) ([source](https://redirect.github.com/babel/babel/tree/HEAD/eslint/babel-eslint-parser)) | [`7.25.8` -> `7.26.5`](https://renovatebot.com/diffs/npm/@babel%2feslint-parser/7.25.8/7.26.5) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>babel/babel (@​babel/eslint-parser)</summary> ### [`v7.26.5`](https://redirect.github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7265-2025-01-10) [Compare Source](https://redirect.github.com/babel/babel/compare/v7.25.9...v7.26.5) ##### 👓 Spec Compliance - `babel-parser` - [#​17011](https://redirect.github.com/babel/babel/pull/17011) Allow the dynamic `import.defer()` form of `import defer` ([@​babel-bot](https://redirect.github.com/babel-bot)) ##### 🐛 Bug Fix - `babel-plugin-transform-block-scoped-functions` - [#​17024](https://redirect.github.com/babel/babel/pull/17024) chore: Avoid calling `isInStrictMode` in Babel 7 ([@​liuxingbaoyu](https://redirect.github.com/liuxingbaoyu)) - `babel-plugin-transform-typescript` - [#​17026](https://redirect.github.com/babel/babel/pull/17026) fix: Correctly generate exported const enums in namespace ([@​liuxingbaoyu](https://redirect.github.com/liuxingbaoyu)) - `babel-parser` - [#​17045](https://redirect.github.com/babel/babel/pull/17045) \[estree] Unify method type parameters handling ([@​JLHwung](https://redirect.github.com/JLHwung)) - [#​17013](https://redirect.github.com/babel/babel/pull/17013) fix: Correctly set position for `@(a.b)()` ([@​liuxingbaoyu](https://redirect.github.com/liuxingbaoyu)) - [#​16996](https://redirect.github.com/babel/babel/pull/16996) \[estree] Adjust the start loc of class methods with type params ([@​nicolo-ribaudo](https://redirect.github.com/nicolo-ribaudo)) - `babel-generator`, `babel-parser`, `babel-plugin-transform-flow-strip-types`, `babel-types` - [#​17028](https://redirect.github.com/babel/babel/pull/17028) Support flow jsx opening element type arguments ([@​JLHwung](https://redirect.github.com/JLHwung)) - `babel-compat-data`, `babel-preset-env` - [#​17031](https://redirect.github.com/babel/babel/pull/17031) fix: More accurate `transform-typeof-symbol` compat data ([@​liuxingbaoyu](https://redirect.github.com/liuxingbaoyu)) - `babel-generator`, `babel-parser`, `babel-types` - [#​17019](https://redirect.github.com/babel/babel/pull/17019) Fix incomplete visitor keys ([@​JLHwung](https://redirect.github.com/JLHwung)) ##### 🔬 Output optimization - `babel-plugin-transform-nullish-coalescing-operator` - [#​16612](https://redirect.github.com/babel/babel/pull/16612) Improve nullish coalescing operator output ([@​liuxingbaoyu](https://redirect.github.com/liuxingbaoyu)) ### [`v7.25.9`](https://redirect.github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7259-2024-10-22) [Compare Source](https://redirect.github.com/babel/babel/compare/v7.25.8...v7.25.9) ##### 🐛 Bug Fix - `babel-parser`, `babel-template`, `babel-types` - [#​16905](https://redirect.github.com/babel/babel/pull/16905) fix: Keep type annotations in `syntacticPlaceholders` mode ([@​liuxingbaoyu](https://redirect.github.com/liuxingbaoyu)) - `babel-helper-compilation-targets`, `babel-preset-env` - [#​16907](https://redirect.github.com/babel/babel/pull/16907) fix: support BROWSERSLIST{,\_CONFIG} env ([@​JLHwung](https://redirect.github.com/JLHwung)) - Other - [#​16884](https://redirect.github.com/babel/babel/pull/16884) Analyze `ClassAccessorProperty` to prevent the `no-undef` rule ([@​victorenator](https://redirect.github.com/victorenator)) ##### 🏠 Internal - `babel-helper-transform-fixture-test-runner` - [#​16914](https://redirect.github.com/babel/babel/pull/16914) remove test options flaky ([@​JLHwung](https://redirect.github.com/JLHwung)) ##### 🏃♀️ Performance - `babel-parser`, `babel-types` - [#​16918](https://redirect.github.com/babel/babel/pull/16918) perf: Make `VISITOR_KEYS` etc. faster to access ([@​liuxingbaoyu](https://redirect.github.com/liuxingbaoyu)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/jaegertracing/jaeger-ui). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45Mi4wIiwidXBkYXRlZEluVmVyIjoiMzkuOTIuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiY2hhbmdlbG9nOmRlcGVuZGVuY2llcyJdfQ==--> Signed-off-by: Mend Renovate <bot@renovateapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )