[pull] master from clockworklabs:master #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
# Description of Changes <!-- Please describe your change, mention any related tickets, and so on here. --> Disables automigrations for column type changes # API and ABI breaking changes <!-- If this is an API or ABI breaking change, please apply the corresponding GitHub label. --> None # Expected complexity level and risk <!-- How complicated do you think these changes are? Grade on a scale from 1 to 5, where 1 is a trivial change, and 5 is a deep-reaching and complex change. This complexity rating applies not only to the complexity apparent in the diff, but also to its interactions with existing and future code. If you answered more than a 2, explain what is complex about the PR, and what other components it interacts with in potentially concerning ways. --> 0 # Testing <!-- Describe any testing you've done, and any testing you'd like your reviewers to do, so that you're confident that all the changes work as expected! --> - [x] Updated smoketests
…or reuse by V8 (#3190) # Description of Changes Refactors the machinery of call_reducer and update_database to a) have smaller pieces that make up the whole so that the code becomes clearer b) extract all the VM-independent stuff so that it can be reused by V8 modules. This is best reviewed commit by commit. # API and ABI breaking changes None. # Expected complexity level and risk 2, it's an important place, but this is doing just code motion. # Testing No semantic changes, just code motion.
# Description of Changes We had weird caching issues in the C#/Unity testsuite. Somehow, they got triggered only as of #3181 merging, and I have no idea why/how. I've restored the `id` field of the checkout step (which is used by the cache step), and this _seems_ to have fixed it. # API and ABI breaking changes None. # Expected complexity level and risk 1 # Testing - [x] It passes on this PR - [x] It passes in a test PR that combines this change with #3182 --------- Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )