Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: better tooling #47

Merged
merged 41 commits into from
Aug 9, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
9f9dacf
lint
MrPunyapal Aug 7, 2024
46a9b3c
chore: Add pest-plugin-type-coverage for code coverage analysis
MrPunyapal Aug 7, 2024
378d27d
chore: Refactor Category model and add missing property annotations
MrPunyapal Aug 7, 2024
276abd0
chore: Refactor Category model and add missing property annotations
MrPunyapal Aug 7, 2024
faab85e
chore: Refactor User model and update property annotations
MrPunyapal Aug 7, 2024
8d7e663
chore: Update ractor.php with import names
MrPunyapal Aug 7, 2024
ec10cb8
lint
MrPunyapal Aug 7, 2024
a88ff86
chore: Update Post model's newEloquentBuilder method signature
MrPunyapal Aug 7, 2024
5d96a95
chore: Refactor tests to use $this instead of from() and get() methods
MrPunyapal Aug 7, 2024
9b9af01
code coverage
MrPunyapal Aug 7, 2024
3b92c0f
chore: Enable dead code analysis in rector.php
MrPunyapal Aug 7, 2024
b1469a4
chore: Enable code quality analysis in rector.php
MrPunyapal Aug 7, 2024
73a90eb
chore: Enable coding style analysis in rector.php
MrPunyapal Aug 7, 2024
713ca5c
chore: Enable type declarations in rector.php
MrPunyapal Aug 7, 2024
6843c49
chore: Enable privatization in rector.php
MrPunyapal Aug 7, 2024
c568b0d
chore: Enable instanceOf check in rector.php
MrPunyapal Aug 7, 2024
256ca5f
chore: Enable early return, strict booleans, and carbon in rector.php
MrPunyapal Aug 7, 2024
c88e9e3
chore: Enable rector preset in rector.php
MrPunyapal Aug 7, 2024
2cf771d
lint
MrPunyapal Aug 7, 2024
3dabc96
chore: Enable php 8.3 features in rector.php
MrPunyapal Aug 7, 2024
894380b
chore: Enable Laravel code quality analysis in rector.php
MrPunyapal Aug 7, 2024
0dee6e2
chore: Enable Laravel if helpers in rector.php
MrPunyapal Aug 7, 2024
2b75bb2
chore: Enable additional Laravel features in rector.php
MrPunyapal Aug 7, 2024
800ba87
chore: Add ordered_class_elements rule to pint.json
MrPunyapal Aug 8, 2024
84ec6bf
chore: Enable modernize_types_casting, no_superfluous_elseif, no_usel…
MrPunyapal Aug 8, 2024
08e13b5
chore: Update PHP coverage to use xdebug instead of none
MrPunyapal Aug 8, 2024
8608deb
chore: Update pint.json with fully qualified strict types and ordered…
MrPunyapal Aug 8, 2024
e11af5c
chore: Update paths in rector.php and remove unnecessary comments
MrPunyapal Aug 8, 2024
221dec0
chore: Update rector.php to enable PHP 8.3 features and use PhpVersio…
MrPunyapal Aug 8, 2024
c2c9ebc
chore: removed `TypedPropertyFromStrictConstructorRector` included in…
MrPunyapal Aug 8, 2024
d6c640c
lint
MrPunyapal Aug 8, 2024
085ac80
chore: Update phpstan.neon to include bleedingEdge.neon
MrPunyapal Aug 8, 2024
943a62d
refactor: Update User model to use list<string> for mass assignable a…
MrPunyapal Aug 8, 2024
c1dc3d4
Update mass assignable attributes in Category and Post models
MrPunyapal Aug 8, 2024
ec8d742
test: Add unit tests for image attribute in Post model
MrPunyapal Aug 8, 2024
507176b
test: Add unit test for getting posts from category relation
MrPunyapal Aug 8, 2024
dc53110
refactor: Remove unnecessary code comments and update pint.json with …
MrPunyapal Aug 8, 2024
afe0048
refactor: Update QueryResolver to use typed arrays for query parameters
MrPunyapal Aug 9, 2024
ae4532d
chore: Update composer.json with project name and keywords
MrPunyapal Aug 9, 2024
ee4763a
refactor: Update PostController to use toString() method for request …
MrPunyapal Aug 9, 2024
f2b6317
Update PHP version requirement to include PHP 8.3 in README.md
MrPunyapal Aug 9, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
lint
  • Loading branch information
MrPunyapal committed Aug 7, 2024
commit 9f9dacfb0d051a5647e605d175e2cf102d98732d
2 changes: 1 addition & 1 deletion app/Http/Requests/UpdatePostRequest.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public function authorize(): bool
*/
public function rules(): array
{
$rules = (new StorePostRequest())->rules();
$rules = (new StorePostRequest)->rules();

return [
...$rules,
Expand Down
12 changes: 6 additions & 6 deletions tests/Unit/QueryResolverTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

get(route('posts.index', $query));

$resolver = new QueryResolver();
$resolver = new QueryResolver;

$sortQuery = $resolver->sortQuery('title');

Expand All @@ -40,7 +40,7 @@

get(route('posts.index', $query));

$resolver = new QueryResolver();
$resolver = new QueryResolver;

$sortArrow = $resolver->sortArrow('title');

Expand All @@ -64,7 +64,7 @@

get(route('posts.index', $query));

$resolver = new QueryResolver();
$resolver = new QueryResolver;

$publishedQuery = $resolver->publishedQuery();

Expand All @@ -84,7 +84,7 @@

get(route('posts.index', $query));

$resolver = new QueryResolver();
$resolver = new QueryResolver;

$publishedLabel = $resolver->publishedLabel();

Expand All @@ -104,7 +104,7 @@

get(route('posts.index', $query));

$resolver = new QueryResolver();
$resolver = new QueryResolver;

$searchQuery = $resolver->searchQuery();

Expand All @@ -124,7 +124,7 @@

get(route('posts.index', $query));

$resolver = new QueryResolver();
$resolver = new QueryResolver;

$searchValue = $resolver->searchValue();

Expand Down