🐞 Fix bug where frontmost application receives key events #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y result in a discrepancy and transmit keyboard events to the front most application. - Keep track of the last key event and use that as a fallback if multiple keys have been inserted into `pressedKeys`.
MrKai77
approved these changes
Dec 14, 2024
MrKai77
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses the issue where pressing multiple keys quickly can cause a discrepancy and send keyboard events to the frontmost application.
I added a new instance variable called
lastKeybecausepressedKeysis aSetwhich is not ordered.Using the new instance variable as a fallback has fixed the issue for me.