chore: remove no-op fullscreenWindowTitle option (electron#39815)

MrHuangJser · Dec 11, 2023 · fa79496 · fa79496
1 parent 9f7f042
commit fa79496
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 16 deletions.
diff --git a/docs/api/structures/browser-window-options.md b/docs/api/structures/browser-window-options.md
@@ -97,9 +97,6 @@
 * `roundedCorners` boolean (optional) _macOS_ - Whether frameless window
   should have rounded corners on macOS. Default is `true`. Setting this property
   to `false` will prevent the window from being fullscreenable.
-* `fullscreenWindowTitle` boolean (optional) _macOS_ _Deprecated_ - Shows
-  the title in the title bar in full screen mode on macOS for `hiddenInset`
-  titleBarStyle. Default is `false`.
 * `thickFrame` boolean (optional) - Use `WS_THICKFRAME` style for frameless windows on
   Windows, which adds standard window frame. Setting it to `false` will remove
   window shadow and window animations. Default is `true`.

diff --git a/shell/browser/native_window_mac.mm b/shell/browser/native_window_mac.mm
@@ -39,7 +39,6 @@
 #include "shell/common/gin_helper/dictionary.h"
 #include "shell/common/node_includes.h"
 #include "shell/common/options_switches.h"
-#include "shell/common/process_util.h"
 #include "skia/ext/skia_utils_mac.h"
 #include "third_party/skia/include/core/SkRegion.h"
 #include "third_party/webrtc/modules/desktop_capture/mac/window_list_utils.h"
@@ -227,14 +226,6 @@ void ReorderChildWindowAbove(NSWindow* child_window, NSWindow* other_window) {
   options.GetOptional(options::kTrafficLightPosition, &traffic_light_position_);
   options.Get(options::kVisualEffectState, &visual_effect_state_);
 
-  if (options.Has(options::kFullscreenWindowTitle)) {
-    EmitWarning(
-        node::Environment::GetCurrent(JavascriptEnvironment::GetIsolate()),
-        "\"fullscreenWindowTitle\" option has been deprecated and is "
-        "no-op now.",
-        "electron");
-  }
-
   bool minimizable = true;
   options.Get(options::kMinimizable, &minimizable);
 

diff --git a/shell/common/options_switches.cc b/shell/common/options_switches.cc
@@ -62,9 +62,6 @@ const char kUseContentSize[] = "useContentSize";
 // Whether window zoom should be to page width.
 const char kZoomToPageWidth[] = "zoomToPageWidth";
 
-// Whether always show title text in full screen is enabled.
-const char kFullscreenWindowTitle[] = "fullscreenWindowTitle";
-
 // The requested title bar style for the window
 const char kTitleBarStyle[] = "titleBarStyle";
 

diff --git a/shell/common/options_switches.h b/shell/common/options_switches.h
@@ -39,7 +39,6 @@ extern const char kAlwaysOnTop[];
 extern const char kAcceptFirstMouse[];
 extern const char kUseContentSize[];
 extern const char kZoomToPageWidth[];
-extern const char kFullscreenWindowTitle[];
 extern const char kTitleBarStyle[];
 extern const char kTabbingIdentifier[];
 extern const char kAutoHideMenuBar[];