avoid firebase messaging import on ios #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
projectfinale
approved these changes
Jan 2, 2023
|
@MrHertal who should we get in touch with for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ios project does not need firebase since that is only used for android. attempting to import firebase messaging in ios project breaks. issue. maybe this works if you actually install the pods and so on but there's a ton of subdependencies with special build configurations etc that I don't really want to deal with especially since that code will never even be called in an ios app.
this changes import of firebase messaging to conditional import since it is only conditionally used on android.