refactor: extract shared utilities for duplicated code patterns - #3
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
refactor: extract shared utilities for duplicated code patterns#3devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…tion, and process execution - BinaryDetection: extract duplicated binary sniff logic from WorkerContext and GitPreCommit into dev.jleak.util.BinaryDetection - LineContext.column(): add helper to encapsulate the repeated columnOffset + matchStart + 1 calculation used by all detectors - Finding.from(): add factory method that derives column from LineContext and uses type.defaultSeverity(), replacing boilerplate in RegexDetector, EntropyDetector, and Scanner (PEM detection) - ProcessRunner: extract exec/readAll from GitPreCommit into reusable dev.jleak.util.ProcessRunner utility Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four duplicated code patterns consolidated into shared utilities:
1.
BinaryDetection(newdev.jleak.util.BinaryDetection)WorkerContext.looksBinary()andGitPreCommit.looksBinary()had identical binary-sniff logic (the latter even commented "duplicated here"). Both now delegate to:2.
LineContext.column(int matchStart)(new method)The column calculation
columnOffset + matchStart + 1was repeated inRegexDetector.detect()andEntropyDetector.detect(). Now:3.
Finding.from(SecretType, LineContext, ...)(new factory)All three finding-creation sites (
RegexDetector,EntropyDetector,ScannerPEM path) repeatednew Finding(type, type.defaultSeverity(), ctx.file, ctx.lineNumber, ctx.columnOffset + start + 1, ...). Now:4.
ProcessRunner(newdev.jleak.util.ProcessRunner)exec()andreadAll()extracted fromGitPreCommitinto a reusable utility for subprocess execution, removing ~30 lines of private helpers.Link to Devin session: https://app.devin.ai/sessions/cd46b49f4b6c4b37a74983b202dd7615
Requested by: @MrGoodNice