Skip to content

Conversation

@akx
Copy link
Contributor

@akx akx commented Mar 31, 2025

This PR makes it possible to specify manifest_path as a static asset path, as you'd do with {% static %}. This makes finding the manifest more agnostic to where on the filesystem it actually is (but it still does need to be locally available to django-vite).

@MrBin99
Copy link
Owner

MrBin99 commented May 9, 2025

I see your point but letting people use static module for loading the file and the file must be readable will maybe confuse people as they think It may be sored elsewhere ?

@akx
Copy link
Contributor Author

akx commented May 12, 2025

[...] and the file must be readable will maybe confuse people as they think It may be sored elsewhere ?

You mean possible confusion since django-vite couldn't read the file if it's stored in a non-local storage? I can of course add documentation to that effect.

@MrBin99
Copy link
Owner

MrBin99 commented Jul 7, 2025

Yeah, I don't know if using the static module when for example a user uses AWS S3 is not confusing for them. Because of this, it will not work and they will need to add more code to handle it.
Therefore, I think that it's better the other way around that you add code because your configuration is different but not the default and I think adding this will break a lot of peoples code.
And just adding documentation is not enougth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants