forked from ironhack-labs/lab-javascript-basic-algorithms
-
Notifications
You must be signed in to change notification settings - Fork 48
[LIS - WDFT - APR23] Victoria Avelar #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
avelarvicky
wants to merge
2
commits into
MrAFerreira:main
Choose a base branch
from
avelarvicky:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,60 @@ | ||
console.log("I'm ready!"); | ||
|
||
|
||
// Iteration 1: Names and Input | ||
let hacker1 = 'Joao'; | ||
console.log(`The driver's name is ${hacker1}!`); | ||
|
||
let hacker2 = 'Victoria'; | ||
console.log(`The navigator's name is ${hacker2}!`); | ||
|
||
// Iteration 2: Conditionals | ||
|
||
// Iteration 2: Conditionals | ||
if (hacker1.length > hacker2.length) { | ||
console.log(`The driver has the longest name, it has ${hacker1.length} characters`); | ||
} | ||
else if (hacker1.length < hacker2.length) { | ||
console.log(`It seems that the navigator has the longest name, it has ${hacker2.length} characters`) | ||
} | ||
else { | ||
console.log(`Wow, you both have equally long names, ${hacker1.length} characters!`) | ||
} | ||
|
||
// Iteration 3: Loops | ||
|
||
|
||
//separated by spaces | ||
const hacker1InCaps = hacker1.toUpperCase(); | ||
|
||
function addSpaces(hacker1InCaps) { | ||
let result = ``; | ||
|
||
for (const char of hacker1InCaps) { | ||
result += char + ` `; | ||
} | ||
return result.trimEnd(); | ||
} | ||
console.log(addSpaces(hacker1InCaps)) | ||
|
||
|
||
//reverse | ||
let reversedHacker1 = ""; | ||
|
||
for (let i = hacker1.length - 1; i >= 0; i--) { | ||
const char = hacker1[i]; | ||
reversedHacker1 += char; | ||
} | ||
console.log(reversedHacker1); | ||
|
||
//lexicographic order | ||
let lexicographicOrder = (hacker1.localeCompare(hacker2)) | ||
|
||
if (lexicographicOrder = -1) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't forget that when you want to compare, you should almost every time use the |
||
console.log("The driver's name goes first.") | ||
} | ||
else if (lexicographicOrder = 1) { | ||
console.log("Yo, the navigator goes first definitely.") | ||
} | ||
else { | ||
console.log("What?! You both have the same name?") | ||
} |
Empty file.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, the lab is asking us to use loops for this iteration.
Separating the word with spaces, can be done using a
for
loop.Here's a possible solution you could've used: