Add some tests for interestingness scripts.#50
Conversation
These are ported from MozillaSecurity#36.
since dir is a shell function on Windows.
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
==========================================
+ Coverage 73.7% 83.01% +9.31%
==========================================
Files 13 13
Lines 1559 1666 +107
==========================================
+ Hits 1149 1383 +234
+ Misses 410 283 -127
Continue to review full report at Codecov.
|
…too, for debugging
nth10sd
left a comment
nth10sd
left a comment
There was a problem hiding this comment.
Thanks for implementing the changes we discussed early on over IRC!
Only some nits to take care of now, so r+
| msg = "CRASHED (Address Sanitizer fault)" | ||
| sta = CRASHED | ||
| elif return_code > 0: | ||
| elif 0 < return_code < 0x80000000: |
There was a problem hiding this comment.
Update the comment in the else block that return_code can now be >= 0x80000000 in the else block.
tests/test_lithium.py
Outdated
| " if len(sys.argv) > 1" | ||
| " else os.listdir('.'))" | ||
| "]")] | ||
| sleep_cmd = [sys.executable, "-c", "import time;time.sleep(3)"] |
There was a problem hiding this comment.
Can we make sleep_cmd accept a variable timeout number, other than 3? I'm not really insistent on this though.
| winreg.KEY_QUERY_VALUE | winreg.KEY_SET_VALUE) | ||
| self.wer_disabled = bool(winreg.QueryValueEx(wer, "Disabled")[0]) | ||
| if not self.wer_disabled: | ||
| winreg.SetValueEx(wer, "Disabled", 0, winreg.REG_DWORD, 1) |
There was a problem hiding this comment.
As discussed over IRC, let's add a comment that we are not sure if we are disabling reporting to Microsoft, or whether we are disabling crash report generation altogether.
3 participants
These are ported from #36.