-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YouTube Regrets - newsletter button and style tweaks #3754
Conversation
So this included:
If so those two things look good! One nice-to-have if it's easy to do would be if the clicking the Newsletter signup button in the main nav could close the signup form. |
@kristinashu 👀 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
I've opened a follow up ticket - YouTube: add newsletter signup to mobile #3756 |
on desktop it looks like there's a very large "empty gap" between the end of the "tunnel" and the first actual content item. Is that because this is on staging, or would that still show up on staging/prod? On a perhaps untested desing point, computer with mouse-wheel based scrolling, rather than touchpad/magic mouse scrolling, the "join mozlla" button is almost always darker than the text above it, and so it feels like a constantly out-of-place element. Does it make sense to separate the button from the content a bit more? (e.g. moving it down to 3/4 view height rather than keeping it close to the text?) (On that note, does it make sense to make the button fade out with the last piece of text, too?) |
I should be able to tweak that by changing the object moving speed with some factor.
Will need design feedback on this. Note that we'll need to leave sufficient room for the long text to show up properly ( e.g.,
I went with the simplest solution to get stuff landed first. Can this be a follow-up? (Need design to chime in) |
Closes #3726
Closes #3727
https://foundation-mofostaging-pr-3754.herokuapp.com/en/campaigns/youtube-regrets/
Added newsletter button (desktop only), MVP tweaks, and some nice-to-have changes.