Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNI: differences between picture background and css background #3795

Closed
taisdesouzalessa opened this issue Oct 17, 2019 · 5 comments · Fixed by #3802
Closed

PNI: differences between picture background and css background #3795

taisdesouzalessa opened this issue Oct 17, 2019 · 5 comments · Fixed by #3802
Assignees
Labels
bug buyer's guide 🛍 Issues related to the buyer's guide engineering

Comments

@taisdesouzalessa
Copy link
Contributor

Describe the bug
There is a small difference of color between the css and the image background on the PNI page, which results in a faint square around the image:
image

URL here: https://foundation.mozilla.org/en/privacynotincluded/

Expected behavior
To have the same color.

Additional context
Changing the class ".bg-gray" to #f5f5f5 solves the issue but I am not sure about how this affects other pages.
image

@taisdesouzalessa taisdesouzalessa added buyer's guide 🛍 Issues related to the buyer's guide bug frontend labels Oct 17, 2019
@taisdesouzalessa
Copy link
Contributor Author

taisdesouzalessa commented Oct 17, 2019

@kristinashu tagging you for triage. Let me know if I should tag Alan instead? Or Gideon?

@kristinashu kristinashu added this to the Nov 11 milestone Oct 17, 2019
@kristinashu
Copy link

Thank you Tais! I've put it in the upcoming milestone.

@mmmavis
Copy link
Collaborator

mmmavis commented Oct 18, 2019

The container background colour #f2f2f2 is a brand color $gray-05. It looks like PNI product images were generated with #f5f5f5 as background. Since regenerating all the images is time-consuming and troublesome, as the simplest solution I can update the container background to #f5f5f5.

@mmmavis mmmavis self-assigned this Oct 18, 2019
@kristinashu
Copy link

Note that the background color used on the product detail page works well with the images
https://foundation.mozilla.org/en/privacynotincluded/products/nintendo-switch/
image

@kristinashu kristinashu modified the milestones: Nov 11, Oct 21 Oct 18, 2019
@taisdesouzalessa
Copy link
Contributor Author

taisdesouzalessa commented Oct 18, 2019

The product detail page bkg color is #f4f4f4

image

I would advocate for the simpler solution Mavis pointed out because it eliminates the issue quickly and the difference between the brand color and the grey we currently have is so small.
Then update the images next year with the grey on brand. @kristinashu - what do you think?

mmmavis added a commit that referenced this issue Oct 21, 2019
* fix #3795 - update container background colour to make image background

* fix #3767 - update badges

* fix #3752 - update homepage banner

* fix broken image path

* fix #3791 - fix icon overlapping issue

* update SCSS variable names

* edited inline comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buyer's guide 🛍 Issues related to the buyer's guide engineering
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants