feat: make number of chunk processing threads configurable #5237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Improvement
BenjaminAmos
commented
Apr 22, 2024
| chunkThreads.setRange(Runtime.getRuntime().availableProcessors()); | ||
| chunkThreads.setLabelFunction(input -> { | ||
| if (input == 0) { | ||
| return "Auto"; |
There was a problem hiding this comment.
Should this string be translated? I am not sure about how dynamic values are handled at the moment.
There was a problem hiding this comment.
no, that seems very international.
| @@ -51,7 +51,7 @@ class ChunkProcessingPipelineTest extends TerasologyTestingEnvironment { | |||
|
|
|||
| @Test | |||
| void simpleProcessingSuccess() throws ExecutionException, InterruptedException, TimeoutException { | |||
| pipeline = new ChunkProcessingPipeline((p) -> null, (o1, o2) -> 0); | |||
| pipeline = new ChunkProcessingPipeline(0, (p) -> null, (o1, o2) -> 0); | |||
There was a problem hiding this comment.
A value of 0 to represent "Automatic" does seem a bit unexpected in hindsight, Do you think another value would make sense? Or maybe wrapping it in a constant would be enough?
soloturn
force-pushed
the
feature/configurable-chunk-threads
branch
from
7b7fc6d
to
5e6b3c1
Compare
soloturn
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
This pull request adds a setting to control the maximum number of available worker threads for chunk processing. More precisely, it controls the number of pooled threads available to
ChunkProcessingPipeline.From testing, I have found that reducing the number of chunk threads can noticeably reduce overall CPU utilisation. Although modern operating systems are very good at multitasking, I have noticed detrimental system-wide effects when the game occupies too much processor time at once. The ideal quantity will vary from player to player and so I think this may be a useful option to have configurable.
How to test
Video Settingsscreen viaSettings->Video.Chunk Threadssetting on the left.Auto.Settings->Videoscreen.