Compile against Java 17 #5162

BenjaminAmos · 2023-11-05T17:33:50Z

Contains

This pull request updates the game to build and run under Java 17. It increases the minimum required JDK version to 17.

Both JUnit and Mockito in engine-tests have been updated since the older versions would not run under Java 17.

How to test

The game should start-up without crashing.
You should also be able to create a new world and start playing in it.
You should be able to place and destroy blocks within the world.
The game should play as before.

Notes

This depends on Add kaniko-precached-jdk17 agent Logistics#9 and build: compile with jdk17 and stop compiling with jdk8 JenkinsAgentPrecachedJava#4 in a complicated fashion. Both of those pull requests technically depend on this pull request, creating a cyclic dependency. Manually pushing the initial builder image may be needed to resolve this.

Closes #3976

…into feature/java-17-upgrade

jdrueckert

Tests out fine 👍

We should also adjust the JDK recommendation in the contributor quickstart guide.
But this is not blocking and can be done in a follow-up PR if desired.

jdrueckert · 2023-11-11T13:21:55Z

engine-tests/src/test/java/org/terasology/engine/entitySystem/PojoEventSystemTests.java

@@ -191,7 +191,7 @@ public void testEventReceiverRegistration() {
        assertEquals(1, receiver.eventList.size());
    }

-    private static class TestEvent extends AbstractConsumableEvent {
+    public static class TestEvent extends AbstractConsumableEvent {


why does this have to be public now?

Java 17 is a lot stricter about accessing private members via reflection. We were able to get away with this before under Java 11 because it only produced a warning.

java.lang.IllegalAccessError: failed to access class org.terasology.engine.entitySystem.PojoEventSystemTests$TestEvent from class org.terasology.engine.entitySystem.PojoEventSystemTests$TestEventHandlerMethodAccess (org.terasology.engine.entitySystem.PojoEventSystemTests$TestEvent is in unnamed module of loader 'app'; org.terasology.engine.entitySystem.PojoEventSystemTests$TestEventHandlerMethodAccess is in unnamed module of loader com.esotericsoftware.reflectasm.AccessClassLoader @319988b0) at org.terasology.engine.entitySystem.PojoEventSystemTests$TestEventHandlerMethodAccess.invoke(Unknown Source) at org.terasology.engine.entitySystem.event.internal.EventSystemImpl$ByteCodeEventHandlerInfo.invoke(EventSystemImpl.java:399) at org.terasology.engine.entitySystem.event.internal.EventSystemImpl.sendConsumableEvent(EventSystemImpl.java:274) at org.terasology.engine.entitySystem.event.internal.EventSystemImpl.send(EventSystemImpl.java:253) at org.terasology.engine.entitySystem.PojoEventSystemTests.testChildEvent(PojoEventSystemTests.java:164) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:728) at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60) at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131) at org.junit.jupiter.engine.extension.SameThreadTimeoutInvocation.proceed(SameThreadTimeoutInvocation.java:45) at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:156) at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:147) at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:86) at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(InterceptingExecutableInvoker.java:103) at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.lambda$invoke$0(InterceptingExecutableInvoker.java:93) at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106) at org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64) at org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45) at org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37) at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.invoke(InterceptingExecutableInvoker.java:92) at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.invoke(InterceptingExecutableInvoker.java:86) at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$7(TestMethodTestDescriptor.java:218) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:214) at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:139) at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:69) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:151) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141) at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138) at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95) at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141) at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138) at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95) at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141) at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138) at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95) at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:35) at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57) at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:54) at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:107) at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:88) at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:54) at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:67) at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:52) at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114) at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86) at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86) at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.processAllTestClasses(JUnitPlatformTestClassProcessor.java:119) at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.access$000(JUnitPlatformTestClassProcessor.java:94) at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor.stop(JUnitPlatformTestClassProcessor.java:89) at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.stop(SuiteTestClassProcessor.java:62) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33) at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94) at jdk.proxy1/jdk.proxy1.$Proxy2.stop(Unknown Source) at org.gradle.api.internal.tasks.testing.worker.TestWorker$3.run(TestWorker.java:193) at org.gradle.api.internal.tasks.testing.worker.TestWorker.executeAndMaintainThreadName(TestWorker.java:129) at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:100) at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:60) at org.gradle.process.internal.worker.child.ActionExecutionWorker.execute(ActionExecutionWorker.java:56) at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:113) at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:65) at worker.org.gradle.process.internal.worker.GradleWorkerMain.run(GradleWorkerMain.java:69) at worker.org.gradle.process.internal.worker.GradleWorkerMain.main(GradleWorkerMain.java:74)

Sounds good 👍

jdrueckert · 2023-11-11T13:22:00Z

engine-tests/src/test/java/org/terasology/engine/recording/EventSystemReplayImplTest.java

@@ -169,7 +169,7 @@ public static class Received {
        }
    }

-    private static class TestEvent extends AbstractConsumableEvent {
+    public static class TestEvent extends AbstractConsumableEvent {


jdrueckert · 2023-11-12T20:09:46Z

Merge strategy:

jdrueckert · 2023-11-13T12:41:02Z

Added a reference to #3976 to the PR description

BenjaminAmos added 8 commits September 23, 2023 22:23

build: use Java 17 for compilation

bf1c87f

build: compile using Java 17 release level

ea60198

doc: update README to reference Java 17

4af4acd

ci: use Java 17 builder

f78439c

chore: update junit to 5.10 and mockito to 5.6

964abfd

Merge branch 'develop' of https://github.com/MovingBlocks/Terasology …

41fc5e5

…into feature/java-17-upgrade

test: fix PojoEventSystemTests under Java 17

627142f

test: fix EventSystemReplayImplTest under Java 17

3063981

BenjaminAmos mentioned this pull request Nov 5, 2023

build: compile with jdk17 and stop compiling with jdk8 MovingBlocks/JenkinsAgentPrecachedJava#4

Closed

jdrueckert added this to the 2023 Revive - Milestone 2 milestone Nov 6, 2023

soloturn approved these changes Nov 7, 2023

View reviewed changes

Merge branch 'develop' into feature/java-17-upgrade

4a0739f

jdrueckert approved these changes Nov 11, 2023

View reviewed changes

jdrueckert mentioned this pull request Nov 12, 2023

Java 17 fixes Terasology/Behaviors#115

Merged

jdrueckert mentioned this pull request Nov 13, 2023

Java 17 compatibility #3976

Closed

BenjaminAmos mentioned this pull request Nov 17, 2023

ci: use java17 builder MovingBlocks/ModuleJteConfig#26

Merged

Merge branch 'develop' into feature/java-17-upgrade

7ff993e

BenjaminAmos merged commit 3aa68c0 into develop Nov 17, 2023
9 checks passed

BenjaminAmos deleted the feature/java-17-upgrade branch November 17, 2023 23:23

BenjaminAmos mentioned this pull request Nov 17, 2023

Terasology now uses Java 17 #5177

Closed

jdrueckert assigned BenjaminAmos Jan 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compile against Java 17 #5162

Compile against Java 17 #5162

BenjaminAmos commented Nov 5, 2023 •

edited by jdrueckert

Loading

jdrueckert left a comment

jdrueckert Nov 11, 2023

BenjaminAmos Nov 11, 2023

jdrueckert Nov 11, 2023

jdrueckert Nov 11, 2023

jdrueckert commented Nov 12, 2023 •

edited

Loading

jdrueckert commented Nov 13, 2023

Compile against Java 17 #5162

Compile against Java 17 #5162

Conversation

BenjaminAmos commented Nov 5, 2023 • edited by jdrueckert Loading

Contains

How to test

Notes

jdrueckert left a comment

Choose a reason for hiding this comment

jdrueckert Nov 11, 2023

Choose a reason for hiding this comment

BenjaminAmos Nov 11, 2023

Choose a reason for hiding this comment

jdrueckert Nov 11, 2023

Choose a reason for hiding this comment

jdrueckert Nov 11, 2023

Choose a reason for hiding this comment

jdrueckert commented Nov 12, 2023 • edited Loading

jdrueckert commented Nov 13, 2023

BenjaminAmos commented Nov 5, 2023 •

edited by jdrueckert

Loading

jdrueckert commented Nov 12, 2023 •

edited

Loading