-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(headless-fixes): remove InputSystem and NuiManager from headlesses #4907
Conversation
This pull request introduces 1 alert when merging 0fc2540 into 01d6c88 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not awake enough to merge this at the moment, but I am hopeful. It should help the speed and signal/noise ratio in MTE tests a lot.
.../main/java/org/terasology/engine/core/subsystem/headless/renderer/HeadlessWorldRenderer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, I can't properly test this until I'm back from vacation. But I left some code-wise review comments at least.
engine/src/main/java/org/terasology/engine/core/modes/StateLoading.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/terasology/engine/core/modes/StateLoading.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/terasology/engine/core/modes/StateLoading.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/terasology/engine/core/modes/StateLoading.java
Outdated
Show resolved
Hide resolved
.../main/java/org/terasology/engine/core/subsystem/headless/renderer/HeadlessWorldRenderer.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/terasology/engine/logic/chat/ChatSystem.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/terasology/engine/logic/console/ConsoleSystem.java
Outdated
Show resolved
Hide resolved
This pull request introduces 1 alert when merging c16ebef into 01d6c88 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested as suggested in the PR description. LGTM
Contains
Removes InputSystem exception from headless
Fixes #4481
Fixes #3793
Removes NuiManager from headless. (yahoo ! no more screens and jpgs at headless mode - MTE, Server, headless client)
How to test
Try game in 4 modes:
You should:
0. enter