Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. NUI editor fixes #2428

Merged
merged 1 commit into from
Aug 2, 2016
Merged

Misc. NUI editor fixes #2428

merged 1 commit into from
Aug 2, 2016

Conversation

rzats
Copy link
Member

@rzats rzats commented Aug 2, 2016

Contains

Some additional minor fixes to the features introduced in #2415:

  • Boolean attributes now default to their inverse value when added.
  • Fixed an issue with NUIEditorItemRenderer not properly displaying identical node values.
  • Fixed an issue with ContextMenuScreen being drawn out of bounds for items below the screen.

How to test

Verify that the fixes work as intended and no other usability bugs remain.

Outstanding before merging

No outstanding issues.

@rzats rzats added Topic: UI/UX Requests, Issues and Changes related to screens, artwork, sound and overall user experience GSOC labels Aug 2, 2016
@rzats rzats added this to the Alpha 3 milestone Aug 2, 2016
@rzats rzats self-assigned this Aug 2, 2016
@GooeyHub
Copy link
Member

GooeyHub commented Aug 2, 2016

Hooray Jenkins reported success with all tests good!

@flo flo merged commit 182fa88 into MovingBlocks:develop Aug 2, 2016
@flo
Copy link
Contributor

flo commented Aug 2, 2016

thanks for the pull request. Having the context menu not go outside of the visible area is really nice.

@Cervator
Copy link
Member

Cervator commented Aug 3, 2016

Cool, does this count as a fix for #1892 then? That sounds very similar but I can't test the exact spot the example is from (discovered #2429 while trying to test it)

@rzats rzats deleted the editor-usage-improvements branch August 3, 2016 07:32
@rzats
Copy link
Member Author

rzats commented Aug 3, 2016

@Cervator: not quite, since this changes ContextMenuScreen that didn't exist when #1892 was created (and is currently only used within the editor). Though I can look into fixing that issue after GSOC 😄

@rzats rzats changed the title [RFR] Misc. NUI editor fixes Misc. NUI editor fixes Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: UI/UX Requests, Issues and Changes related to screens, artwork, sound and overall user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants